Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expansion effect from the large collapsing headers #2864

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jul 28, 2023

What

Remove the expansion effect on the large collapsible header's triangle.

Fixes #2726

Before:

image

After:

image

(Both are being hovered.)

Checklist

@abey79
Copy link
Member Author

abey79 commented Jul 28, 2023

While working on this, I noticed this subtle visual bug (which is unrelated to this PR). I'm not sure where it comes from but it's been there for a while. I initially thought it might be related to the global non-zero expansion setting, but its not (ie. this is the demo from the PR were that setting was globally set to 0).

image image

@abey79 abey79 added the ui concerns graphical user interface label Jul 28, 2023
@abey79 abey79 requested a review from martenbjork July 28, 2023 13:01
Copy link
Collaborator

@martenbjork martenbjork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@martenbjork
Copy link
Collaborator

I filed a separate issue about the borders here: #2865

@abey79 abey79 merged commit 1e83dea into main Jul 28, 2023
22 of 23 checks passed
@abey79 abey79 deleted the antoine/no-expansion-large-header-2726 branch July 28, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hover effect in selection view toggle
3 participants