Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compliance fixes #131

Closed
joerussbowman opened this issue Jul 2, 2014 · 4 comments
Closed

compliance fixes #131

joerussbowman opened this issue Jul 2, 2014 · 4 comments

Comments

@joerussbowman
Copy link

Would it be possible to move the compliance fixes up from requests-oauthlib up to oauthlib in order for more oauthlib projects to take advantage of them?

@ib-lundgren
Copy link
Member

Looking at the small selection we have here we certainly could. I added them here because I thought there would be much wider discrepancies and wanted to keep the "dirt" out of oauthlib.

I think a fairly naive "automatic fixing of common errors" compatibility mode could be added to the oauthlib clients, possibly off by default.

Fancy digging into this?

@joerussbowman
Copy link
Author

Maybe, I'm currently working on an oauthlib implementation for tornado. I'm focusing on the providers first. Let me take a look at this when I get to working on clients. The plan is for the project I'm working on to replace the current auth module included with tornado. That supports some of the providers you have tweaks for so it is a bridge I will be crossing.

@ib-lundgren
Copy link
Member

Sounds good.

Will ping you here in case I get around to it myself :)

On Wed, Jul 9, 2014 at 3:06 AM, Joseph Bowman [email protected]
wrote:

Maybe, I'm currently working on an oauthlib implementation for tornado.
I'm focusing on the providers first. Let me take a look at this when I get
to working on clients. The plan is for the project I'm working on to
replace the current auth module included with tornado. That supports some
of the providers you have tweaks for so it is a bridge I will be crossing.


Reply to this email directly or view it on GitHub
#131 (comment)
.

@ib-lundgren
Copy link
Member

With the exception on LinkedIn all fixes are now in oauthlib master thanks to oauthlib/oauthlib#268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants