-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client side renderers options #2219
base: main
Are you sure you want to change the base?
feat: client side renderers options #2219
Conversation
client/components/editor.vue
Outdated
@@ -63,6 +63,8 @@ import { AtomSpinner } from 'epic-spinners' | |||
import { Base64 } from 'js-base64' | |||
import { StatusIndicator } from 'vue-status-indicator' | |||
|
|||
import renderersQuery from 'gql/admin/rendering/rendering-query-renderers.gql' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not right to call admin query here but duplicating the same query in editor section also do not feel right. Any suggestions how to proceed?
From my point of wiew this is finished - please let me know if any changes are still required. |
While this work because you are admin, the renderers query will fail for normal users as the As for the query itself, inline it directly in editor.vue. External queries are gradually being removed from the project to reduce complexity. e.g.: import gql from 'graphql-tag'
// ...
query: gql`
{
rendering {
...
}
}
` |
@NGPixel - I added commits handling Your suggestions |
Merget latest changes from |
Merged latest changes from |
@NGPixel I too would like to prevent our internal data from going to some external server, so I'm very interested in this PR. What is missing for it to be merged? |
Is there a plan when this PR will be merged to the next version of wikijs? It is a great product and I have the same issue that i want to prevent potential data-leaks to external services i can't control. Do we have to wait until wikijs-vnext is released until this feature is added? |
any updates? |
1 similar comment
any updates? |
this is a significant security issue for many companies, which is preventing widespread adoption. What can we do to get this PR complete? |
Addresses #2167
Implementation Plan