Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed-up builds with buildGoCache #155

Merged
merged 5 commits into from
Mar 21, 2024
Merged

speed-up builds with buildGoCache #155

merged 5 commits into from
Mar 21, 2024

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Nov 1, 2023

While this takes of them time from the go build, it seems that the majority of time is still consumed by building the sqlite database.
I tried to isolate this code into its own derivation but the generator seems to have cross dependencies to the rest of the code base.

@Mic92 Mic92 requested a review from a team as a code owner November 1, 2023 09:37
@Mic92 Mic92 requested review from masad-frost and removed request for a team November 1, 2023 09:37
@masad-frost
Copy link
Member

@cdmistman rerouting this to you

@@ -0,0 +1,46 @@
archive/tar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recommendation for this would be to have a github action that just updates this file after pushes to master automatically. After all it's a performance optimization and it causes too much friction/merge conflicts to have this being updated in pull requests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like that but for updating this file: https://gist.github.com/Broxzier/1ed980b8b3822d213e98042fc6a92040

Copy link
Contributor

@cdmistman cdmistman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5 mins down to 20s - amazing! thank you!

@cdmistman cdmistman enabled auto-merge (squash) November 20, 2023 20:27
@cdmistman
Copy link
Contributor

@replit/micromanager merge CI isn't running because semaphore

@ryantm ryantm disabled auto-merge March 21, 2024 18:31
@ryantm ryantm merged commit fd1b5f6 into replit:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants