-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use exec collectors instead of http for support bundles #186
Use exec collectors instead of http for support bundles #186
Conversation
56e0f53
to
ebffbc7
Compare
@@ -18,6 +18,50 @@ stringData: | |||
name: {{ include "replicated.supportBundleName" . }} | |||
spec: | |||
collectors: | |||
- exec: | |||
name: replicated-app-updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought - could we have the name
be common between these so that the files end up in the same directory in the support bundle? any reason we might not want that?
looking at these docs: https://troubleshoot.sh/docs/collect/exec/#included-resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is really good idea Craig!
@FourSigma could we add something small to these tests to validate that we get these files in the support bundle? for replicated-sdk/.github/workflows/main.yaml Lines 503 to 519 in c6b880f
for replicated-sdk/.github/workflows/main.yaml Lines 560 to 576 in c6b880f
|
@cbodonnell Will do. My only concern is if the |
@FourSigma I believe the tests use the Chainguard build process as well (source). That Dockerfile seems to only be there for local testing at this point. It might actually be good to add I'll approve the PR as it all looks good to me, but ping here again if you do end up adding that test snippet or anything else. |
cc46065
to
2343ca3
Compare
What this PR does / why we need it:
http
collectors (they were not working)curl
/license/info
and/app/info
SDK endpoints to return additional detailsWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Notice the new
![Screenshot 2024-06-11 at 3 48 56 PM](https://private-user-images.githubusercontent.com/8316724/338741652-8051a1e2-891d-4f0b-8a8c-9a5b3b744be9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMTcxMzcsIm5iZiI6MTcyNjExNjgzNywicGF0aCI6Ii84MzE2NzI0LzMzODc0MTY1Mi04MDUxYTFlMi04OTFkLTRmMGItOGE4Yy05YTViM2I3NDRiZTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTJUMDQ1MzU3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9M2Q5ODQxYWU2YzA5YzQwNjdiMDY0MmE3ZmQ1NTI0Y2ViYTVjY2FjODZlMzE5ZGY2ZTIxYzViNGVhMDM2ZTQzZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.P4qXjP4uMvTjlc3Z4q_xZuBN9VUt5Z7gMXgDNCTg-Uk)
replicated-app*
exec foldersDoes this PR require documentation?