Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description clarification, grammar correction #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Evidlo
Copy link

@Evidlo Evidlo commented Dec 5, 2018

Please make sure my description of a Condition is correct.

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #196   +/-   ##
========================================
  Coverage      10.4%   10.4%           
  Complexity      401     401           
========================================
  Files           390     390           
  Lines         11013   11013           
  Branches       1236    1236           
========================================
  Hits           1146    1146           
  Misses         9633    9633           
  Partials        234     234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ac41c...885ccb0. Read the comment docs.

@renyuneyun
Copy link
Owner

Hi there,
Thank you for the work, and apologize for the delay.
Some bits of this seem to clash with #190 , as both of you edited something in common. I'll wait until #190 merged (if not taking too long) and manually resolve the conflict.
Anyway, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants