fix(gitea): immortal PRs for Gitea #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proton-ab
changed the title
|
Pushed a fix to
|
This was referenced Apr 20, 2020
|
🎉 This PR is included in version 19.216.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6018
As per go-gitea/gitea#10413, Gitea now supports exposing name of deleted branch on closed PR, however this is done by
label, notref. (refmust always be a valid reference)This PR changes
toRenovatePRto always accesslabelwhen fetching branch name, as it will contain proper branch name for both open and closed PRs.This effectively solves the issue of Renovate recreating closed PRs on Gitea, however we should keep the immortal message until Gitea 1.12 is officially released.
The change is fully backwards compatible.