fix(sbt-plugin): add new default registry URL

[george-wilson-rea]

Changes

Change the default repository for SBT plugin lookup to https://repo1.maven.org/maven2/

Context

The bintray service has been sunset and now https://repo.scala-sbt.org/scalasbt/ redirects to a mirror that no longer receives updates. Renovate should just default to maven.org for sbt plugins as it does for sbt packages. See this page for additional context: https://www.scala-sbt.org/1.x/docs/Bintray-For-Plugins.html

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

you need to verify that it still works with older plugins.

[HonkingGoose]

Did you check if there are readme files related to this change that need to be updated?

[rarkins]

Needs at least one test on a "real" repository to make sure it works end to end. This is the type of change which would pass all unit tests while stopping plugin updating working altogether if something were wrong

[george-wilson-rea]

@HonkingGoose When I search for "sbt" in the docs directory, I don't see anything that would need updating. Should I be looking anywhere else?

@rarkins How should I test this on a "real" repository? Could you please elaborate?

[rarkins]

A public repo on GitHub.com which needs updates affected by this PR.

[george-wilson-rea]

Here's a repo: https://github.com/george-wilson-rea/renovate-scala-plugins

In plugins.sbt, sbt-scoverage is set to 2.0.11, which is not the latest version. I expect it to be updated to 2.0.12 but with recommended config, that doesn't happen.

[george-wilson-rea]

Here's another repo, with an overridden sbt plugin config. Interestingly, sbt-scoverage is still not getting updated. I'm not sure what's going wrong here.
https://github.com/george-wilson-rea/renovate-scala-plugins-fixed

[george-wilson-rea]

Interestingly, it looks like sbt plugins are working by default, but for some reason sbt-scoverage specifically doesn't work with either setup. I might have misdiagnosed the problem here.
How can I investigate what's going wrong with sbt-scoverage?

[HonkingGoose]

@HonkingGoose When I search for "sbt" in the docs directory, I don't see anything that would need updating. Should I be looking anywhere else?

Hmm, the convention is that each manager/datasource/platform has a readme file. Maybe the sbt-plugin has no readme yet. It should have a readme though!

Please search in a similar directory for examples. 😉

[HonkingGoose]

Please add a readme to both the datasource and manager.

[george-wilson-rea]

@HonkingGoose The sbt manager has a readme saying

Extracts Maven artifact dependencies for SBT.

which is accurate. I have added some minimal readmes to the sbt-package and sbt-plugin datasources. Is there anything else I should say in these documents?

[zharinov]

Now we don't need test changes, check it out:

• 29648 more changes george-wilson-rea/renovate#2

[george-wilson-rea]

I've merged the latest suggestions from @zharinov, which has unfortunately dismissed the approving review. I've re-requested review per the contribution guidelines. Sorry for the churn.

[HonkingGoose]

Some docs changes:

• Follow one sentence per line pattern
• Make a ordered list of the steps Renovate takes by default
• Small style fixes

[george-wilson-rea]

Thanks for enabling auto-merge @rarkins . Could you, or someone else, please also approve so that this gets merged? Your last review was dismissed when I merged @zharinov 's suggestions.

[viceice]

otherwise LGTM

[renovate-release]

🎉 This PR is included in version 37.421.5 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 37.421.5

Your semantic-release bot 📦🚀