Renovate merged a PR with failing Tests

[feanil]

What would you like help with?

I think I found a bug

How are you running Renovate?

Mend Renovate hosted app on github.com

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

No response

Please tell us more about your question or problem

openedx/edx-platform#35016 was merged by Renovate automatically, even though it seems to have failed the "build assets" check on the PR. I'm not sure how renovate determines that tests have passed or if there is noting wrong with our configuration that's causing this.

Logs (if relevant)

No response

[rarkins]

No need for logs, as the PR history gives enough details:

Renovate enabled platform automerge, and GitHub did the merging - not Renovate.

You need to choose between one of these:

• Set better branch protections so that such tests are mandatory and GitHub won't merge until they're passed, or
• Disable GitHub's native automerge on this repo if you are unable to improve the branch protections, or
• Set platformAutomerge=false in Renovate config so that it waits to do automerging itself. Unlike GitHub native automerging, Renovate won't merge if any tests are failed or still in progress.

[github-actions[bot]]

Hi there,

A maintainer decided this is not a bug, and behaving as designed. The maintainer will explain why this behavior is correct. To avoid confusing future readers, we will close this Discussion.

We want Bug-type Discussions to be about things that we rate as bugs. For more details, please read our development docs about bug handling.

If this bug report makes you think of an idea for a new feature, or how to improve a current feature, feel free to create a new Suggest an Idea Discussion.

Thanks, the Renovate team