Preset schedules are considered invalid by breejs/later

[muffl0n]

What would you like help with?

Other

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Gitlab

Please tell us more about your question or problem

Like described in https://docs.renovatebot.com/key-concepts/scheduling/#scheduling-syntax, Renovate uses breejs/later for parsing its schedule configuration.

While testing some expressions I came upon a weird behaviour I can't explain.

Given this script

var later = require('@breejs/later');

console.log('before 4am', later.parse.text('before 4am')) // taken from https://docs.renovatebot.com/presets-schedule/#scheduledaily
console.log('before 4:00am', later.parse.text('before 4:00am'))

I'm getting this output:

-> % node test.js
before 4am { schedules: [], exceptions: [], error: 7 }
before 4:00am { schedules: [ { t_b: [Array] } ], exceptions: [], error: -1 }

So breejs/later states, that there is an error in the configuration Renovate uses in its preset schedule:daily.

What am I missing?

Logs (if relevant)

-> % npm ls
later@ /tmp
└── @breejs/[email protected]

[muffl0n]

Found it myself: Since #397 (2b533ff) there's a function fixShortHours:

renovate/lib/config/migration.ts

Lines 18 to 20 in 8e6f89b

	export function fixShortHours(input: string): string {
	return input.replace(regEx(/( \d?\d)((a|p)m)/g), '$1:00$2');
	}