terraform.updateArtifacts() hangs for ever

[zgpcy]

How are you running Renovate?

Self-hosted Renovate

If you're self-hosting Renovate, tell us what version of Renovate you run.

latest

If you're self-hosting Renovate, select which platform you are using.

github.com

Was this something which used to work for you, and then stopped?

It used to work, and then stopped

Describe the problem

On 2023-11-23T08:02:49 we run renovate github action and you can see in relevant debug logs section that the action was canceled by Github after 6 hours (the default timeout for jobs).

We found this commit 8eefcbc and we wrote the following nodejs code to test the changes with the values from our infrastructure.

Minimal Reproduction

const {execSync} = require('child_process');
let newConstraint = ">= 2.36.0, 2.46.0"
//remove surplus .0 version
while (newConstraint.split('.').length - 1 > 2) {
  newConstraint = newConstraint.replace(RegExp('\\.0$'), '');
  console.log("Looping",newConstraint)
  execSync('sleep 1'); 
}

As you can see below it loops for ever.

❯ node test.js
Looping >= 2.36.0, 2.46
Looping >= 2.36.0, 2.46
Looping >= 2.36.0, 2.46
Looping >= 2.36.0, 2.46
Looping >= 2.36.0, 2.46
Looping >= 2.36.0, 2.46
^C

Relevant debug logs

Logs

2023-11-23T08:06:49.9066817Z DEBUG: terraform.updateArtifacts(******.tf) (repository=******, branch=renovate/azuread-2.x)
2023-11-23T08:06:49.9087152Z DEBUG: Updating constraint ">= 2.36.0, 2.41.0" to replace "2.41.0" with "2.46.0" for "hashicorp/azuread" (repository=******, branch=renovate/azuread-2.x)
2023-11-23T14:04:44.0477050Z ##[error]The operation was canceled.

Have you created a minimal reproduction repository?

I have linked to a minimal reproduction in the description above

[viceice]

@secustor @rarkins it seems we need to revert or fix that asap

[secustor]

I'm looking into this right now

[secustor]

#26049

[cdenneen]

@secustor @viceice looks like this is back: "renovateVersion": "37.173.0"

DEBUG: Setting current branch to main (repository=gitops/infra/eks_cluster, branch=renovate/aws-5.x)
DEBUG: latest commit (repository=gitops/infra/eks_cluster, branch=renovate/aws-5.x)
       "branchName": "main",
       "latestCommitDate": "2024-03-20T15:17:58+00:00"
DEBUG: manager.getUpdatedPackageFiles() reuseExistingBranch=false (repository=gitops/infra/eks_cluster, branch=renovate/aws-5.x)
DEBUG: Starting search at index 128 (repository=gitops/infra/eks_cluster, packageFile=versions.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Found match at index 128 (repository=gitops/infra/eks_cluster, packageFile=versions.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Contents updated (repository=gitops/infra/eks_cluster, packageFile=versions.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Value is not updated (repository=gitops/infra/eks_cluster, packageFile=modules/eks_addons/main.tf, branch=renovate/aws-5.x)
       "manager": "terraform",
       "expectedValue": "5.41.0",
       "foundValue": "5.39.1"
DEBUG: Starting search at index 128 (repository=gitops/infra/eks_cluster, packageFile=modules/eks_addons/main.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Found match at index 128 (repository=gitops/infra/eks_cluster, packageFile=modules/eks_addons/main.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Contents updated (repository=gitops/infra/eks_cluster, packageFile=modules/eks_addons/main.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Value is not updated (repository=gitops/infra/eks_cluster, packageFile=modules/eks/main.tf, branch=renovate/aws-5.x)
       "manager": "terraform",
       "expectedValue": "5.41.0",
       "foundValue": "5.39.1"
DEBUG: Starting search at index 156 (repository=gitops/infra/eks_cluster, packageFile=modules/eks/main.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Found match at index 156 (repository=gitops/infra/eks_cluster, packageFile=modules/eks/main.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: Contents updated (repository=gitops/infra/eks_cluster, packageFile=modules/eks/main.tf, branch=renovate/aws-5.x)
       "depName": "aws"
DEBUG: terraform.updateArtifacts(versions.tf) (repository=gitops/infra/eks_cluster, branch=renovate/aws-5.x)
DEBUG: Updating constraint ">= 4.0.0, >= 4.21.0, >= 4.33.0, >= 4.36.0, >= 4.47.0, >= 5.0.0, >= 5.38.0, 5.39.1" to replace "5.39.1" with "5.41.0" for "hashicorp/aws" (repository=gitops/infra/eks_cluster, branch=renovate/aws-5.x)

[cdenneen]

Just tried this with latest "renovateVersion": "37.261.0". Same issue.

[viceice]

please open a new discussion with a minimal reproduction and reference this discussion

[github-actions[bot]]

Hi there,

Please do not unnecessarily @ mention maintainers like @rarkins or @viceice. Doing so causes annoying mobile notifications and makes it harder to maintain this repository.

For example, never @ mention a maintainer when you are creating a discussion if your desire is to get attention. This is rude behavior, just like shouting out your coffee order in a Starbucks before it's your turn.

It's OK to comment in an issue or discussion after multiple days or weeks. But please, still don't @ mention people. The maintainers try to answer most discussions, but they can't answer all discussions. If you're still not getting an answer, take a look at the information you've given us and see if you can improve it.

Thanks, the Renovate team