Throw if connect() is called before claiming access #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougReeder
approved these changes
May 27, 2022
raucao
requested changes
May 27, 2022
test/unit/authorize-suite.js
Outdated
| test.assert(e.message.includes("scope"), true, "Did not throw an error that had a message describing the problem"); | ||
| sawError = true; | ||
| } | ||
| test.assert(sawError, true, "Did not throw an error when scope was not set"); |
There was a problem hiding this comment.
The descriptions of the assertions should be human-readable language of what is being asserted. When the test fails, it will then show that e.g. "throws an error when scope is not set" was expected, but the source code did not satisfy the expectation.
There was a problem hiding this comment.
Thanks for the feedback! I've updated the assertions' text so that they should match the convention, let me know if not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1198
Hello! I ran into this issue and I thought I'd go ahead and submit a fix since it seems like a nice small change.