Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defunct warning about wrangler.toml bindings #9565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

acusti
Copy link
Contributor

@acusti acusti commented Jun 5, 2024

Two months ago, cloudflare announced that:

you can now configure Pages projects using wrangler.toml — the same configuration file format that is already used for configuring Workers.

Considering that change, it seems like this warning is defunct and will cause unnecessary complexity for users when trying to set up a remix cloudflare pages application.

Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: f75178a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 5, 2024

Hi @acusti,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 5, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@irvinebroque
Copy link

Thanks for opening this! On the Cloudflare side – this is accurate and this warning is no longer necessary

@acusti
Copy link
Contributor Author

acusti commented Jun 16, 2024

just rebased this from latest upstream main

@acusti
Copy link
Contributor Author

acusti commented Jun 29, 2024

just rebased it from latest upstream main again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants