Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully terminate dev server #8230

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Dec 6, 2023

Closes: #6871

  • Docs
  • Tests

Testing Strategy: trying it out on my own computer

This is not yet working because of ESM/CJS interop. When I try this out in an example Remix project, I get this error:

/Users/lpsinger/src/remix/build/node_modules/@remix-run/dev/dist/devServer/liveReload.js:15
var exitHook = require('exit-hook');
               ^

Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/lpsinger/src/remix/node_modules/exit-hook/index.js from /Users/lpsinger/src/remix/build/node_modules/@remix-run/dev/dist/devServer/liveReload.js not supported.

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 1b787a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lpsinger lpsinger changed the base branch from main to dev December 6, 2023 17:05
@lpsinger lpsinger force-pushed the gracefully-terminate-dev-server branch 2 times, most recently from d16521b to 2a342e9 Compare December 6, 2023 17:48
@lpsinger lpsinger marked this pull request as draft December 7, 2023 13:19
@lpsinger lpsinger force-pushed the gracefully-terminate-dev-server branch from 2a342e9 to 1b787a7 Compare January 23, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev server v2 kills arc sandbox ungracefully, not giving sandbox plugins a chance to clean up
2 participants