Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #7948

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Patch 1 #7948

wants to merge 4 commits into from

Conversation

FDiskas
Copy link

@FDiskas FDiskas commented Nov 8, 2023

If I have nested ENV variables it is not populated

FIRST_NAME="Joe"
SURNAME="Doe"
FULL_NAME="${FIRST_NAME} ${SURNAME}"

It should combine

source .env && echo $FULL_NAME   
Joe Doe

Copy link

changeset-bot bot commented Nov 8, 2023

⚠️ No Changeset found

Latest commit: 1299400

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 8, 2023

Hi @FDiskas,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 8, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

I'll defer to @pcattori here but I think our original intention with dotenv integration is to provide simple/minimal support out of the box, but if you needed more complex logic you would do that in your custom server/scripts (similar to our stance on remix-server versus a custom express server). The additional dotenv-expand package could be argued as something that belongs in userland since it's nor part of the built-in/minimal dotenv support.

@FDiskas
Copy link
Author

FDiskas commented Nov 9, 2023

I fully understand and partially agree. The idea is that: by default env variables works like that by default, but the framework parses env variables differently. As an end user I couldn't understand why it is not working 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants