Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-node): relax typings for createReadableStreamFromReadable #7495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

estyrke
Copy link

@estyrke estyrke commented Sep 20, 2023

This enables NodeJS.ReadWriteStream to be used with it.

  • Docs
  • Tests

Testing Strategy:

This allows the Chakra UI example at https://github.com/remix-run/examples/blob/main/chakra-ui/ to be converted to v2 according to https://remix.run/docs/en/main/start/v2#removal-of-exported-polyfills

That said, I have only tested this by copy/pasting the code into my local entry.server.tsx.

This enables NodeJS.ReadWriteStream to be used with it.
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

⚠️ No Changeset found

Latest commit: 282139f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 20, 2023

Hi @estyrke,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 20, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 added runtime:node feat:fetch Issues related to @remix-run/web-fetch labels Sep 20, 2023
@nmackey
Copy link

nmackey commented Oct 18, 2023

would be great to get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed feat:fetch Issues related to @remix-run/web-fetch runtime:node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants