refactor(remix-dev): don't use Express for server ping #7087
Conversation
|
|
Hi @TrySound, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
| const bodyBuffer = await new Promise<Buffer>((resolve, reject) => { | ||
| let buf: any[] = []; | ||
| req.on("data", (chunk) => buf.push(chunk)); | ||
| req.on("end", () => resolve(Buffer.concat(buf))); | ||
| req.on("error", (err) => reject(err)); | ||
| }); | ||
| const body = JSON.parse(bodyBuffer.toString()); |
There was a problem hiding this comment.
Interesting thing is this api available since node v16.
import { json } from 'node:stream/consumers';
await json(stream)
Related to remix-run#7086 Express is very big. Native http server can do the same. https://packagephobia.com/result?p=express
|
Can remix/packages/remix-dev/package.json Line 42 in 4441ff2 |
|
Not yet. There are other cases it hs used for. Will take time to remove completely. |
MichaelDeBoey
changed the title
Related to #7086
Express is very big. Native http server can do the same.