Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(other-api/adapter) Improve Cloudflare Workers examples #6084

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xanderberkein
Copy link
Contributor

This PR updates the Cloudflare Workers API examples to include mode in the createRequestHandler. This is needed with the unstable dev server (and harmless without it).

This PR updates the Cloudflare Workers API examples to include `mode` in the `createRequestHandler`. This is needed with the unstable dev server (and harmless without it).
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2023

⚠️ No Changeset found

Latest commit: 82b3b62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 16, 2023

Hi @xanderberkein,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 16, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

Should we add this to all of the examples on this page? cc @pcattori

@xanderberkein
Copy link
Contributor Author

xanderberkein commented Jul 24, 2023

@brophdawg11 The cloudflare adapters are actually the only adapters where mode is not defaulted to process.env.

However, the Cloudflare Workers adapter examples here are a bit outdated now. Since 1.18.1, the cloudflare-workers template doesn't use the cloudflare-workers adapter anymore, but it uses the cloudflare adapter directly. So the cloudflare-workers section of this page might need a full revisist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants