-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-react): avoid dynamic import of relative file #5007
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @MatthieuCoelho, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
70ae33b
to
4e4aed0
Compare
Hi @MatthieuCoelho! Are you still interested in getting this one merged? If so, please rebase onto latest |
4e4aed0
to
70ae33b
Compare
70ae33b
to
2c398e4
Compare
Yes absolutely, it should be good :) |
Could you provide an example application demonstrating the bug that this fixes? |
@brophdawg11 In root.tsx If you build and start this sandbox : https://codesandbox.io/p/sandbox/quirky-frost-9h2wwv
|
e7aa36e
to
6438090
Compare
Can you explain why you need a
Can you use a root-relative or absolute path for your juse-case? |
We want to ‘build once, run everywhere’, since the public path is dynamically generated at runtime we can’t use root-relative or absolute paths . Using a relative path is the only way. |
6438090
to
92e0a74
Compare
Problem :
Cause :
https://bugs.webkit.org/show_bug.cgi?id=201692
Solution :
I tested it successfully on safari and safari mobile.