Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides/mdx): mention including highlight.js css file #4571

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dwjohnston
Copy link

The current example shows using rehype-highlight. However, without a highlight.js css file, only monospaced text will appear.

Given that the example is mentioning rehype-highlight it think it's worth also mentioning including the CSS, or remove rehype-highlight from the example.

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

⚠️ No Changeset found

Latest commit: 5ffdf0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 11, 2022

Hi @dwjohnston,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 11, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@dwjohnston
Copy link
Author

I could include an example of the change to your root.tsx that is required. However, that might clutter the documenation/distract.

The required change to root.tsx is:

//root.tsx
+ import styles from 'highlight.js/styles/vs2015.css';
+
+ export const links: LinksFunction = () => {
+     return [{ rel: "stylesheet", href: styles }];
+ };

@MichaelDeBoey MichaelDeBoey changed the title Update MDX documentation - mention including highlight.js css. docs(guides/mdx): mention including highlight.js css file Mar 9, 2023
The current example shows using rehype-highlight. However, without a highlight.js css file, only monospaced text will appear. 

Given that the example is mentioning rehype-highlight it think it's worth also mentioning including the CSS, or remove rehype-highlight from the example.
@@ -201,6 +201,11 @@ exports.mdx = async (filename) => {
};
```

The above configuration parses markdown to insert [highlight.js][highlightjs] friendly DOM elements. To have the syntax highlighting appear, you need also include a highlight.js css file. See [Surfacing Styles][surfacing-styles].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The above configuration parses markdown to insert [highlight.js][highlightjs] friendly DOM elements. To have the syntax highlighting appear, you need also include a highlight.js css file. See [Surfacing Styles][surfacing-styles].
The above configuration parses the markdown to insert [highlight.js][highlightjs] friendly DOM elements. To have the syntax highlighting appear, you will also need to include the highlight.js css file. See also [surfacing styles][surfacing-styles].

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworded things a bit.
I'm fine with adding this remark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants