-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-react): make actionData
available in meta
function
#3534
Conversation
Hi @kenneth-gray, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
actionData
available in meta
function
Hi @kenneth-gray! Are you still interested in getting this one merged? If so, please rebase onto latest |
Yes very interested, will sort it out 👍 |
|
Wanted to get the merge conflicts out of the way before sinking any more time into the PR. |
Will attempt to update changes into V2 and sort out all the testing as well. Probably won't be in a good position till the very end of the week. |
@kenneth-gray Any update on this one? I'd happily help to get this over the finish line if there is anything I can do. I'm desperately looking for this feature |
@timkraut Feel free to take my contribution and make it your own. I ended up getting V1 working, but not finding the time to make it work for V2. |
Hey folks 👋
Thought I'd give this a go as it didn't take long - no hard feelings if you feel it's the wrong way to go of course!
Things to consider:
data
=>loaderData
, but that's a breaking change to the API.data
was renamed toloaderData
, shouldparentsData
be renamed toparentsLoaderData
?http
only), so that if your strategy is to use session cookies for error messaging then you'd be able to access that too.Closes: #3524
Testing Strategy:
This test covers this code:
integration/meta-test.ts
(added additional test)