Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typecheck for @remix-run/cloudflare-workers failure #6010

Closed
1 task done
kubens opened this issue Apr 5, 2023 · 2 comments
Closed
1 task done

Typecheck for @remix-run/cloudflare-workers failure #6010

kubens opened this issue Apr 5, 2023 · 2 comments
Assignees
Labels
bug Something isn't working feat:typescript

Comments

@kubens
Copy link

kubens commented Apr 5, 2023

What version of Remix are you using?

Latest

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

Create new Remix project, and run npm run typecheck:

$ npx create-remix@latest

? Where would you like to create your app? ./my-remix-app
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix App Server if you're unsure; it's easy to change deployment targets. 
Cloudflare Workers
? TypeScript or JavaScript? TypeScript

$ npm run typecheck

Expected Behavior

Should not show errors

Actual Behavior

It showing:

Found 44 errors in 4 files.

Errors  Files
     1  app/routes/_index.tsx:1
    27  node_modules/@cloudflare/workers-types/index.d.ts:4
     1  node_modules/@types/react/index.d.ts:2898
    15  node_modules/typescript/lib/lib.dom.d.ts:25
@AdiRishi
Copy link
Contributor

AdiRishi commented Apr 8, 2023

I ran into this today too when setting up a new cloudflare pages project. Add the following to your tsconfig.json file

{
    "exclude": ["node_modules"],
    "compilerOptions": {
        "skipLibCheck": true,
    }
}

lpsinger added a commit to lpsinger/remix that referenced this issue May 23, 2023
MichaelDeBoey pushed a commit to lpsinger/remix that referenced this issue Aug 8, 2023
@markdalgleish
Copy link
Member

This should be fixed by #6925 which is due to go out in Remix v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat:typescript
Projects
No open projects
Status: Closed
Development

No branches or pull requests

4 participants