Add exact and strict support to renderRoutes #4826
Conversation
There was a problem hiding this comment.
I think that we should be testing renderRoutes directly, not just integration. What I would like to see tested would be two types of routes:
exactexactandstrict
You can test strict without exact, but you just need to make sure that you understand how that works (see https://reacttraining.com/react-router/core/api/Route/strict-bool). The <Route> tests don't actually test this, just strict and exact.
For each one, there should be two cases: one where it should match and one where it should not. For example, this is the <Route exact> test from the react-router package: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/modules/__tests__/Route-test.js#L240-L270
| } | ||
| ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
I don't think that this second route is necessary.
|
I wrote tests for |
| rendered.push(route), | ||
| renderRoutes(routes) | ||
| ) | ||
| beforeEach(() => rendered = []) |
There was a problem hiding this comment.
Every other before/after each call uses this style.
beforeEach(() => {
rendered = []
})| component: Comp, | ||
| }] | ||
|
|
||
| renderToString(<StaticRouter location='/' context={{}}>{renderRoutes(routes)}</StaticRouter>) |
There was a problem hiding this comment.
No need to cram everything into one line.
renderToString(
<StaticRouter location='/' context={{}}>
{renderRoutes(routes)}
</StaticRouter>
)| expect(rendered.length).toEqual(1) | ||
| expect(rendered[0]).toMatch(routeToMatch) | ||
| }) | ||
| describe('Switch usage', () => { |
There was a problem hiding this comment.
Leave a blank line before the describe.
| expect(rendered.length).toEqual(1) | ||
| expect(rendered[0]).toMatch(routeToMatch) | ||
| }) | ||
| it('renders the first matched route in nested routes', () => { |
|
Should be good to go ! |
|
That's a lot of tests! LGTM too. Good work, @lith-light-g! |
|
Any idea when this PR will find its way into a release ... would really help me out with a server rendering example I'm writing? |
|
+1 for more info when this will be released. |
|
If anyone is interested I've forked and published as @amurdock/react-router-config until the next release. |
My attempt at writing tests for #4728