Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior prop to <ScrollRestoration /> #11701

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

h3rmanj
Copy link

@h3rmanj h3rmanj commented Jun 21, 2024

Non-breaking continuation of #10318.

Adds an optional behavior prop to <ScrollRestoration /> that are passed through to the scrollTo calls. This allows the user to specify a specific behavior for scroll restoration, while setting a different value globally with css.

The original PR was closed due to being breaking, and not going through a proposal for considering more generic behavior. A proposal was opened in #10328, but hasn't received any more activity for a year. Due to the inactivity, I feel the ScrollRestoration works fine other than missing a way to specify behavior, and a generic approach seems unnecessary.

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: b9fd4f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Minor
react-router Minor
react-router-dom-v5-compat Minor
react-router-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 21, 2024

Hi @h3rmanj,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 21, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@h3rmanj
Copy link
Author

h3rmanj commented Jun 24, 2024

Seems to add 0.07 kB to dist bundle and 0.08 kB to umd bundle, so I had to bump the filesize property in package.json from 17.2 kB to 17.3 kB. Not sure if that's the proper way to do it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant