fix: pre/code links don't change color when :active in dark mode #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...unlike normal links in dark mode, or both types of links in light mode. This is the same issue as <remix-run/remix-website#262>, though more subtle: the dark mode plain color rule has higher specificity than the text-inherit rule, so dark:inherit is needed to allow the :active color to continue to be applied.
brookslybrand
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...unlike normal links in dark mode, or both types of links in light mode.
(Test page: route/route)
This is the same issue as remix-run/remix-website#262: the dark mode plain color rule has higher specificity than the text-inherit rule, so dark:inherit is needed to allow the :active color to continue to be applied. In this case it is more subtle (which is why I initially though there is no problem here), as links are still distinguishable as links.