Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

@remax/runtime #841

Merged
merged 5 commits into from
Apr 23, 2020
Merged

@remax/runtime #841

merged 5 commits into from
Apr 23, 2020

Conversation

noyobo
Copy link
Contributor

@noyobo noyobo commented Apr 22, 2020

No description provided.

@vercel
Copy link

vercel bot commented Apr 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/remaxjs/remax/qrr72iidb
✅ Preview: https://remax-git-remax-runtime.remaxjs.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 366b3a6:

Sandbox Source
quirky-wind-41mry Configuration

@Darmody
Copy link
Contributor

Darmody commented Apr 22, 2020

https://github.com/remaxjs/remax/blob/master/.codesandbox/ci.json 这个文件也要加一个 runtime

@Darmody
Copy link
Contributor

Darmody commented Apr 22, 2020

@Darmody
Copy link
Contributor

Darmody commented Apr 22, 2020

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #841 into master will decrease coverage by 1.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   94.72%   93.66%   -1.06%     
==========================================
  Files         324      324              
  Lines        3429     3550     +121     
  Branches      475      503      +28     
==========================================
+ Hits         3248     3325      +77     
- Misses        181      225      +44     
Impacted Files Coverage Δ
packages/remax-runtime/src/AppContainer.ts 77.77% <ø> (ø)
packages/remax-runtime/src/AppInstanceContext.ts 100.00% <ø> (ø)
packages/remax-runtime/src/Container.ts 96.55% <ø> (ø)
packages/remax-runtime/src/PageInstanceContext.ts 100.00% <ø> (ø)
packages/remax-runtime/src/ReactPortal.ts 100.00% <ø> (ø)
...ages/remax-runtime/src/SyntheticEvent/constants.ts 100.00% <ø> (ø)
...-runtime/src/SyntheticEvent/createCallbackProxy.ts 100.00% <ø> (ø)
...emax-runtime/src/SyntheticEvent/stopPropagation.ts 100.00% <ø> (ø)
packages/remax-runtime/src/VNode.ts 100.00% <ø> (ø)
packages/remax-runtime/src/actionId.ts 100.00% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f5fd9...366b3a6. Read the comment docs.

@noyobo noyobo requested a review from Darmody April 23, 2020 02:15
@yesmeck yesmeck merged commit f20e0b3 into master Apr 23, 2020
@yesmeck yesmeck deleted the remax-runtime branch April 23, 2020 03:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants