Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: 修复节点卸载后回调没从 Page 上删除的问题 #1822

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Jan 11, 2022

close #1780

@yesmeck yesmeck changed the title fix: 修复节点卸载后毁掉没从 Page 上删除的问题 fix: 修复节点卸载后回调没从 Page 上删除的问题 Jan 11, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b285840:

Sandbox Source
one Configuration

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #1822 (b285840) into master (e7750fd) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
+ Coverage   90.37%   90.39%   +0.02%     
==========================================
  Files         391      391              
  Lines        4756     4768      +12     
  Branches      692      692              
==========================================
+ Hits         4298     4310      +12     
  Misses        449      449              
  Partials        9        9              
Impacted Files Coverage Δ
packages/remax-runtime/src/Container.ts 96.92% <100.00%> (+0.09%) ⬆️
packages/remax-runtime/src/VNode.ts 100.00% <100.00%> (ø)
packages/remax-runtime/src/hostConfig/index.ts 97.75% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7750fd...b285840. Read the comment docs.

@yesmeck yesmeck merged commit 0a10885 into master Jan 11, 2022
@yesmeck yesmeck deleted the fix-listener-not-removed branch January 11, 2022 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant