Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: 移除 @umi/babel-plugin-auto-css-modules ,减少 babel-preset-remax 编译依赖 #1817

Merged
merged 4 commits into from
Jan 8, 2022

Conversation

watsonhaw5566
Copy link
Contributor

@watsonhaw5566 watsonhaw5566 commented Jan 7, 2022

close #1815

引用 @umi/babel-plugin-auto-css-modules 时候安装
@umijs/deps 用途是用来做 transform 测试 和 使用 bable types /traverse
https://github.com/umijs/umi/blob/820440f95410501de8e5895fe7595e6c80ac6924/packages/babel-plugin-auto-css-modules/src/index.test.ts#L10
其他并无用途,如果是这个需要安装整个 @umijs/deps 确实十分冗余。
所以我 fork 了 @umi/babel-plugin-auto-css-modules 单独做了引用,解决这个问题。

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6b0491:

Sandbox Source
one Configuration

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #1817 (f6b0491) into master (2ef5efc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
+ Coverage   90.33%   90.37%   +0.03%     
==========================================
  Files         390      391       +1     
  Lines        4737     4756      +19     
  Branches      682      692      +10     
==========================================
+ Hits         4279     4298      +19     
  Misses        449      449              
  Partials        9        9              
Impacted Files Coverage Δ
...ackages/babel-plugin-auto-css-modules/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef5efc...f6b0491. Read the comment docs.

@watsonhaw5566
Copy link
Contributor Author

watsonhaw5566 commented Jan 7, 2022

@umi/utils 还是会安装 @umijs/deps ,暂不要合并,我看看怎么处理一下

@watsonhaw5566
Copy link
Contributor Author

@yesmeck 改好了,麻烦有空时候 cc 谢谢

@yesmeck yesmeck merged commit 356d08b into remaxjs:master Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[问题]通过 umijs 间接引入了太多多余编译依赖
2 participants