fix: 移除 options 中的 default，在运行时动态判断以避免 CI 错误

remaxjs · May 20, 2020 · 6bec914 · 6bec914
1 parent ec7b67e
commit 6bec914
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/packages/remax-cli/src/build/web.ts b/packages/remax-cli/src/build/web.ts
@@ -13,7 +13,7 @@ export default function buildWeb(api: API, options: Options): webpack.Compiler {
  const compiler = webpack(webpackOptions);
 
  if (options.watch) {
- const designatedPort = options.port;
+ const designatedPort = options.port ?? 3000;
 
  detect(designatedPort, (err, port) => {
  if (err) {

diff --git a/packages/remax-cli/src/index.ts b/packages/remax-cli/src/index.ts
@@ -50,7 +50,6 @@ export function run(args: any, callback?: yargs.ParseCallback) {
  describe: '指定端口号',
  alias: 'p',
  type: 'number',
- default: 3000,
  })
  .showHelpOnFail(false);
 

diff --git a/packages/remax-types/src/index.ts b/packages/remax-types/src/index.ts
@@ -20,7 +20,7 @@ export interface Options {
  UNSAFE_wechatTemplateDepth: number | { [key: string]: number };
  configWebpack?: (params: { config: WebpackConfig; webpack: any }) => void;
  plugins: Plugin[];
- port: number;
+ port?: number;
  one?: boolean;
  notify?: boolean;
  watch?: boolean;