Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gains chart and Lift chart #71

Merged
merged 6 commits into from
Oct 25, 2017
Merged

Add Gains chart and Lift chart #71

merged 6 commits into from
Oct 25, 2017

Conversation

reiinakano
Copy link
Owner

Fixes #63

@reiinakano reiinakano changed the title Add Gains chart and Lift chart. Fixes #63 Add Gains chart and Lift chart Oct 25, 2017
@reiinakano reiinakano merged commit 3378c28 into master Oct 25, 2017
@reiinakano reiinakano deleted the add-cumulative-gains-chart branch October 25, 2017 14:49
theainerd
theainerd reviewed Oct 27, 2017
View reviewed changes
Copy link

@theainerd theainerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's giving UnboundLocalError: local variable 'pc2' referenced before assignment

@reiinakano
Copy link
Owner Author

reiinakano commented Oct 27, 2017 •
edited
Loading

Can you give me the code that generates this error? All the tests pass and the examples run on my laptop so I'm not sure what's wrong.

Also, there is no instance of 'pc2' in the scikit-plot codebase so the error probably isn't with this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theainerd theainerd theainerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reiinakano @theainerd