Update examples to be v.0.3.0+ compliant #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @reiinakano , here's my PR! 👍
This commit solves Issue #62 and updates Jupyter notebook examples to be compliant with the latest version. Some things to note:
Summary
Demos that used the plotters API were removed. Some examples demonstrate by showing how to do it with the factory, and by the
plotters
API. Since both of them are deprecated, I just removed the other and focused on the updated way to do it.Add a .gitignore file to untrack .ipynb_checkpoints I think they're not needed so I have git ignore them.
Explicitly pass a parameter to
cmap
to avoid matplotlib deprecation warning. This seems a bit weird for me. My environment has matplotlib 2.0.2 and of course scikit-plot 0.3.1. When I callplot_roc_curve
orplot_precision_curve
, I encounter a deprecation warning on the use ofspectral
orspectral_r
.So whenever I do this:
This appears:
Although I checked the code in the repo and it's actually supplying
nipy_spectral
. Hmmm, not sure if it's just an environment problem for me. Either way, I solve it by explicitly passing the cmap parameter instead.I committed a lot (almost per file), I can rebase my commits after your suggestion/revisions/review.
Thank you so much! Sorry if this PR took me a long time, thesis happened. 😞