Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include React 16 in peer dependencies. #543

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AndrewSouthpaw
Copy link

Based on #537, and from my own testing, the latest Reflux works fine with React 16. This PR updates the peer dependency to include React 16.

@AndrewSouthpaw
Copy link
Author

I don't understand why this build is failing, it builds fine locally. My only guess is that this build uses npm 2.14.4 and I use npm 5.6.0.

Thoughts?

@jrm2k6
Copy link

jrm2k6 commented Mar 24, 2018

Any update on this? Would be great to have this merged! Let me know if I can help in any way

@aewing
Copy link

aewing commented May 8, 2018

It looks like the build is failing because the React version is specified as 15 in the .travis.yml, but react-dom is installing 16.2.0

@aewing aewing mentioned this pull request May 8, 2018
@aewing
Copy link

aewing commented May 8, 2018

Given the current state of the tests, the easiest solution here is to modify the .travis.yml to install react-dom at the version specified in ENV. The better solution would probably be to involve react-dom/test-utils in the Component test and to update the .travis.yml to instead install React 16. As it stands now the tests fail under React 16 as they are using the deprecated React.createClass method.

@AndrewSouthpaw
Copy link
Author

AndrewSouthpaw commented May 9, 2018

Interesting. If they're using React.createClass I wonder why it doesn't blow up for React 16...

@eek
Copy link
Contributor

eek commented May 9, 2018

Also the npm WARN peerDependencies

The peer dependency react included from reflux will no longer
be automatically installed to fulfill the peerDependency in npm 3+.

Your application will need to depend on it explicitly.

React needs to be moved from peerDependecies to dependencies

@aewing
Copy link

aewing commented May 9, 2018

@AndrewSouthpaw I believe createClass is only used for the component tests.

@aewing
Copy link

aewing commented May 9, 2018

FWIW, I had modified the travis build to install react-dom at the specified version in #545 and received a log4js error during build, so I think that is also likely to be an impediment to a merge.

@AndrewSouthpaw
Copy link
Author

Ah, that makes sense.

@ied3vil
Copy link

ied3vil commented Mar 24, 2019

You can go ahead and use https://github.com/ied3vil/reflux-react-16

Also, if you feel you want to improve, you can PR

@carolineapp
Copy link

Is there any update on this? I too would like to update the React version but not sure if it will break anything.

@ied3vil
Copy link

ied3vil commented Dec 13, 2019

Just use the repo i posted above your comment, we have been using it in production with React 16.x without issues for a year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants