Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes in Markdown component #179

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

murilo-cunha
Copy link
Contributor

Hi, really like the framework!

Used it to build a static website (GH pages), and had to make a few adjustments to the Markdown component and figured I'd submit a PR here.

Summary of changes/commits:

  1. Use rehype-raw plugin in react-markdown to omit markdown comments (i.e.: <!-- comment -->)
    1. See react-markdown's issue for more info
  2. Use chakra-ui's UnorderedList, OrderedList and ListItem
    1. Otherwise the list was not aligned with the rest of the text
    2. Feel free to drop the last commit if this is not the desired implementation

Thanks!

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@picklelo picklelo merged commit 9d16582 into reflex-dev:main Dec 26, 2022
ACucos1 pushed a commit to ACucos1/rd-pynecone that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants