Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Identifier -> string. #540

Merged
merged 6 commits into from
Jun 3, 2021
Merged

Update Identifier -> string. #540

merged 6 commits into from
Jun 3, 2021

Conversation

yildirayunlu
Copy link
Contributor

@yildirayunlu yildirayunlu commented Jun 2, 2021 •
edited by refine-bot
Loading

Test me! 'MASTER'
Link to IDENTIFIER-UPDATE

Test documentation! 'MASTER'
Link to IDENTIFIER-UPDATE

@refine-bot
Copy link
Contributor

Hello from PR Helper

Is your PR ready for review and processing? Mark the PR ready by including #pr-ready in a comment.

If you still have work to do, even after marking this ready. Put the PR on hold by including #pr-onhold in a comment.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021 •
edited
Loading

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 87.2 62.28 74.51 86.7
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 87.2 62.28 74.51 86.7
_core/src/components 100 100 33.33 100
_ index.ts 100 100 33.33 100
_core/src/components/authenticated 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons 100 100 50 100
_ index.ts 100 100 50 100
_core/src/components/buttons/clone 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/create 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/delete 92.31 57.14 33.33 91.67
_ index.tsx 92.31 57.14 33.33 91.67 58-60
_core/src/components/buttons/edit 94.44 100 50 94.44
_ index.tsx 94.44 100 50 94.44 35
_core/src/components/buttons/export 96.67 68.75 100 96.08
_ index.tsx 96.67 68.75 100 96.08 49,86
_core/src/components/buttons/import 74.42 41.67 42.86 72.97
_ index.tsx 74.42 41.67 42.86 72.97 50,55-72
_core/src/components/buttons/list 93.33 75 50 93.33
_ index.tsx 93.33 75 50 93.33 27
_core/src/components/buttons/refresh 95.24 100 50 94.74
_ index.tsx 95.24 100 50 94.74 41
_core/src/components/buttons/save 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/show 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/containers 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/containers/admin 95.83 28.57 50 95.12
_ index.tsx 95.83 28.57 50 95.12 82,106
_core/src/components/containers/resource 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/containers/routeProvider 92.59 83.33 71.43 91.49
_ index.tsx 92.59 83.33 71.43 91.49 55,71,87,160
_core/src/components/crud 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/crud/create 96.3 77.78 100 96.3
_ index.tsx 96.3 77.78 100 96.3 52
_core/src/components/crud/edit 97.06 84.21 50 96.88
_ index.tsx 97.06 84.21 50 96.88 118
_core/src/components/crud/list 100 81.25 100 100
_ index.tsx 100 81.25 100 100 21-36
_core/src/components/crud/show 96.88 88.64 50 96.67
_ index.tsx 96.88 88.64 50 96.67 96
_core/src/components/fields 100 100 9.09 100
_ index.ts 100 100 9.09 100
_core/src/components/fields/boolean 100 83.33 100 100
_ index.tsx 100 83.33 100 100 20,22
_core/src/components/fields/date 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/email 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/file 100 75 100 100
_ index.tsx 100 75 100 100 18
_core/src/components/fields/image 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/markdown 100 50 100 100
_ index.tsx 100 50 100 100 8
_core/src/components/fields/number 100 80 100 100
_ index.tsx 100 80 100 100 34
_core/src/components/fields/richtext 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/tag 100 75 100 100
_ index.tsx 100 75 100 100 9
_core/src/components/fields/text 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/url 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper 84 50 66.67 84
_ index.tsx 84 50 66.67 84 33-40,45
_core/src/components/layoutWrapper/components 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/layoutWrapper/components/footer 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/header 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/layout 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/offLayoutArea 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/sider 87.5 50 40 87.5
_ index.tsx 87.5 50 40 87.5 26,44
_core/src/components/layoutWrapper/components/title 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/notification 88.89 75 83.33 88.89
_ index.tsx 88.89 75 83.33 88.89 62-67
_core/src/components/notification/components 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/notification/components/notificationProgress 100 75 100 100
_ index.tsx 100 75 100 100 17
_core/src/components/pages 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/pages/error 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/pages/login 88.89 100 25 88.89
_ background.svg 100 100 100 100
_ index.tsx 85 100 25 85 44-47
_ refine.svg 100 100 100 100
_ styles.ts 100 100 100 100
_core/src/components/pages/ready 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/table 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/table/components 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/table/components/filterDropdown 90.63 50 100 90
_ index.tsx 90.63 50 100 90 28,35,46
_core/src/contexts/admin 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/auth 89.13 58.33 61.54 85.71
_ index.tsx 89.13 58.33 61.54 85.71 6-10
_core/src/contexts/components 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/data 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/notification 93.94 87.5 88.89 93.1
_ actionTypes.ts 100 100 100 100
_ index.ts 100 100 100 100
_ notificationContext.tsx 91.67 83.33 80 90.48 11,39
_core/src/contexts/resource 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/translation 90 100 75 90
_ index.tsx 90 100 75 90 9
_core/src/definitions 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/config 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers 100 100 50 100
_ index.ts 100 100 50 100
_core/src/definitions/helpers/importCSVMapper 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers/userFriendlySeconds 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/render 88.89 75 100 88.89
_ index.tsx 88.89 75 100 88.89 12
_core/src/definitions/table 95.77 73.68 100 94.92
_ index.ts 95.77 73.68 100 94.92 90,99,112
_core/src/definitions/upload 86.67 50 80 86.67
_ index.ts 86.67 50 80 86.67 37-38
_core/src/hooks 88.71 41.67 73.33 88.14
_ index.ts 100 100 100 100
_ useFileUploadState.ts 88.24 25 100 85.71 18,35
_ useListResourceQueries.ts 83.87 75 60 83.87 11,27,48,52,58
_core/src/hooks/admin 100 100 100 100
_ index.ts 100 100 100 100
_ useMutationMode.ts 100 100 100 100
_ useSyncWithLocation.ts 100 100 100 100
_ useTitle.tsx 100 100 100 100
_core/src/hooks/admin/useWarnAboutChange 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth 100 100 40 100
_ index.ts 100 100 40 100
_core/src/hooks/auth/useAuthenticated 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/useGetIdentity 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/useLogin 100 50 100 100
_ index.ts 100 50 100 100 24-26
_core/src/hooks/auth/useLogout 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/usePermissions 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/data 67.88 41.3 70.24 69.67
_ index.ts 100 100 72.73 100
_ useApiUrl.ts 100 100 100 100
_ useCreate.ts 83.33 100 60 82.61 64-70
_ useCreateMany.ts 85.71 100 60 85 57-61
_ useCustom.ts 100 75 100 100 38
_ useDelete.ts 58.97 36.36 69.23 62.32 80,84-85,89,112-143,153-168,184-187,204-207
_ useDeleteMany.ts 59.42 44.83 69.23 62.9 81,85-86,90,113-146,160-163,178-191
_ useList.ts 100 100 100 100
_ useMany.ts 85.71 0 66.67 85.71 32-34
_ useOne.ts 78.57 0 66.67 78.57 31-35
_ useUpdate.ts 59.46 44.44 69.23 62.12 84,88-89,93,116-148,163-178,195
_ useUpdateMany.ts 59.46 48.15 69.23 62.12 84,88-89,93,117-151,166-181,198
_core/src/hooks/fields 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/fields/useCheckboxGroup 100 50 100 100
_ index.ts 100 50 100 100 33-34
_core/src/hooks/fields/useRadioGroup 100 50 100 100
_ index.ts 100 50 100 100 31-32
_core/src/hooks/fields/useSelect 93.75 62.5 85.71 92
_ index.ts 93.75 62.5 85.71 92 49,89
_core/src/hooks/form 92.86 60 33.33 90.91
_ index.ts 100 100 20 100
_ useForm.ts 90 60 100 88.46 118-122
_core/src/hooks/form/useCloneForm 100 92.31 100 100
_ index.ts 100 100 100 100
_ useCloneForm.ts 100 92.31 100 100 62
_core/src/hooks/form/useCreateForm 65.91 25 22.22 65
_ index.ts 100 100 100 100
_ useCreateForm.ts 64.29 25 12.5 64.1 100-119,127-128,133-136,142
_core/src/hooks/form/useDrawerForm 65.22 37.1 42.86 60.98
_ index.ts 100 100 0 100
_ useDrawerForm.ts 63.64 37.1 50 60 63-65,73-75,84-85,111-127
_core/src/hooks/form/useEditForm 71.43 50 33.33 69.35
_ index.ts 100 100 100 100
_ useEditForm.ts 70.59 50 27.27 68.85 145-177,186-187,192-195,201
_core/src/hooks/form/useModalForm 68.18 43.48 42.86 65.85
_ index.ts 100 100 0 100
_ useModalForm.ts 66.67 43.48 50 65 92-94,102-105,114-115,142-156
_core/src/hooks/form/useStepsForm 83.33 53.85 25 81.82
_ index.ts 100 100 0 100
_ useStepsForm.ts 80 53.85 33.33 80 41,55
_core/src/hooks/navigation 100 75 100 100
_ index.ts 100 75 100 100 11,19,29,39,47,56-60
_core/src/hooks/notification 100 100 100 100
_ index.ts 100 100 100 100
_ useNotification.ts 100 100 100 100
_core/src/hooks/notification/useCancelNotification 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/hooks/redirection 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource/useMenu 100 77.78 100 100
_ index.tsx 100 77.78 100 100 27,47,52
_core/src/hooks/resource/useResource 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource/useResourceWithRoute 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/show 100 92.86 100 100
_ index.ts 100 100 100 100
_ useShow.ts 100 92.86 100 100 29
_core/src/hooks/table 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/table/useEditableTable 84.21 50 42.86 88.24
_ index.ts 100 100 0 100
_ useEditableTable.ts 82.35 50 50 87.5 51,56
_core/src/hooks/table/useTable 71.95 69.23 40 68.18
_ index.ts 100 100 100 100
_ useTable.ts 71.25 69.23 25 67.69 59,76-85,122-139,144-146
_core/src/hooks/translate 100 75 100 100
_ index.ts 100 100 100 100
_ useGetLocale.ts 100 100 100 100
_ useSetLocale.ts 100 100 100 100
_ useTranslate.ts 100 75 100 100 9
_core/test 100 100 100 100
_ dataMocks.ts 100 100 100 100
_ index.tsx 100 100 100 100
_json-server/src 82.54 53.45 79.41 82.41
_ index.ts 82.54 53.45 79.41 82.41 15-24,33-35,127-138,198,221,225,233,235,238-240
_json-server/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/custom 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/src 78.29 47.62 84.38 76.36
_ index.ts 78.29 47.62 84.38 76.36 30-39,46-54,58-68,188-193,231,245,249,257,259,262-264
_nestjsx-crud/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/custom 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_strapi/src 87.93 59.65 87.1 86.73
_ dataProvider.ts 87.93 59.65 87.1 86.73 14-23,131-132,168,191,195,203,205,208-210
_strapi/src/helpers 100 100 100 100
_ auth.ts 100 100 100 100
_strapi/test/auth 100 100 100 100
_ index.mock.ts 100 100 100 100
_strapi/test/dataProvider 100 100 100 100
_ index.mock.ts 100 100 100 100

@yildirayunlu yildirayunlu changed the title [wip] Update Identifier -> string. Update Identifier -> string. Jun 2, 2021
@omeraplak omeraplak linked an issue Jun 2, 2021 that may be closed by this pull request
identifier'ı sadece string kabul eder hale getirelim #533
Closed
@omeraplak
Copy link
Member

@yildirayunlu conflict'leri çözdükten sonra bunu merge edelim gitsin

@refine-bot refine-bot merged commit 3a7bc5e into master Jun 3, 2021
@omeraplak omeraplak deleted the identifier-update branch June 3, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrrmk mhrrmk mhrrmk left review comments

@omeraplak omeraplak omeraplak approved these changes

@biskuvit biskuvit Awaiting requested review from biskuvit

@necatiozmen necatiozmen Awaiting requested review from necatiozmen

Assignees
No one assigned
Labels
auto-merge pr-ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

identifier'ı sadece string kabul eder hale getirelim
4 participants
@yildirayunlu @refine-bot @omeraplak @mhrrmk