Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return types of some functions #494

Merged
merged 15 commits into from
Jun 1, 2021
Merged

fix return types of some functions #494

merged 15 commits into from
Jun 1, 2021

Conversation

umutzd
Copy link
Contributor

@umutzd umutzd commented May 28, 2021 •
edited by refine-bot
Loading

@umutzd umutzd added help wanted Extra attention is needed to be continued labels May 28, 2021
@umutzd umutzd self-assigned this May 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2021 •
edited
Loading

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 79.37 52.37 61.02 78.67
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 79.37 52.37 61.02 78.67
_core/src/components 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/authenticated 25 0 0 33.33
_ index.tsx 25 0 0 33.33 8-17
_core/src/components/buttons 100 100 50 100
_ index.ts 100 100 50 100
_core/src/components/buttons/clone 94.12 0 50 94.12
_ index.tsx 94.12 0 50 94.12 28
_core/src/components/buttons/create 92.86 0 50 92.86
_ index.tsx 92.86 0 50 92.86 23
_core/src/components/buttons/delete 92.31 57.14 33.33 91.67
_ index.tsx 92.31 57.14 33.33 91.67 58-60
_core/src/components/buttons/edit 94.44 100 50 94.44
_ index.tsx 94.44 100 50 94.44 35
_core/src/components/buttons/export 61.67 18.75 66.67 58.82
_ index.tsx 61.67 18.75 66.67 58.82 49,55-91,96
_core/src/components/buttons/import 74.42 41.67 42.86 72.97
_ index.tsx 74.42 41.67 42.86 72.97 51,56-73
_core/src/components/buttons/list 93.33 75 50 93.33
_ index.tsx 93.33 75 50 93.33 27
_core/src/components/buttons/refresh 95.24 100 50 94.74
_ index.tsx 95.24 100 50 94.74 41
_core/src/components/buttons/save 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/show 94.12 37.5 50 94.12
_ index.tsx 94.12 37.5 50 94.12 32
_core/src/components/containers 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/containers/admin 95.83 28.57 50 95.12
_ index.tsx 95.83 28.57 50 95.12 82,106
_core/src/components/containers/resource 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/containers/routeProvider 13.21 0 0 14.89
_ index.tsx 13.21 0 0 14.89 26-166
_core/src/components/crud 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/crud/create 95.83 85.71 100 95.83
_ index.tsx 95.83 85.71 100 95.83 46
_core/src/components/crud/edit 96.77 78.13 50 96.55
_ index.tsx 96.77 78.13 50 96.55 109
_core/src/components/crud/list 100 81.25 100 100
_ index.tsx 100 81.25 100 100 21-36
_core/src/components/crud/show 96.77 77.78 50 96.55
_ index.tsx 96.77 77.78 50 96.55 84
_core/src/components/fields 100 100 9.09 100
_ index.ts 100 100 9.09 100
_core/src/components/fields/boolean 100 83.33 100 100
_ index.tsx 100 83.33 100 100 20,22
_core/src/components/fields/date 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/email 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/file 100 75 100 100
_ index.tsx 100 75 100 100 14
_core/src/components/fields/image 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/markdown 100 50 100 100
_ index.tsx 100 50 100 100 8
_core/src/components/fields/number 100 80 100 100
_ index.tsx 100 80 100 100 34
_core/src/components/fields/richtext 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/tag 100 75 100 100
_ index.tsx 100 75 100 100 9
_core/src/components/fields/text 57.14 100 0 80
_ index.tsx 57.14 100 0 80 12
_core/src/components/fields/url 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper 84 50 66.67 84
_ index.tsx 84 50 66.67 84 33-40,45
_core/src/components/layoutWrapper/components 100 100 85.71 100
_ index.ts 100 100 85.71 100
_core/src/components/layoutWrapper/components/error 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/footer 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/header 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/layout 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/offLayoutArea 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/sider 87.5 50 40 87.5
_ index.tsx 87.5 50 40 87.5 26,44
_core/src/components/layoutWrapper/components/title 75 100 0 100
_ index.tsx 75 100 0 100
_core/src/components/notification 77.78 50 66.67 77.78
_ index.tsx 77.78 50 66.67 77.78 20,30-34,64-69
_core/src/components/notification/components 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/notification/components/notificationProgress 100 75 100 100
_ index.tsx 100 75 100 100 17
_core/src/components/pages 100 100 50 100
_ index.tsx 100 100 50 100
_core/src/components/pages/login 59.26 100 0 59.26
_ background.svg 100 100 100 100
_ index.tsx 45 100 0 45 36-60
_ refine.svg 100 100 100 100
_ styles.ts 100 100 100 100
_core/src/components/pages/ready 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/table 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/table/components 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/table/components/filterDropdown 15.63 0 0 16.67
_ index.tsx 15.63 0 0 16.67 10-63
_core/src/contexts/admin 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/auth 89.13 58.33 61.54 85.71
_ index.tsx 89.13 58.33 61.54 85.71 6-10
_core/src/contexts/components 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/data 62.07 100 15.38 62.07
_ index.tsx 62.07 100 15.38 62.07 7-17
_core/src/contexts/notification 87.88 75 77.78 86.21
_ actionTypes.ts 100 100 100 100
_ index.ts 100 100 100 100
_ notificationContext.tsx 83.33 66.67 60 80.95 11,27-29,39
_core/src/contexts/resource 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/translation 90 100 75 90
_ index.tsx 90 100 75 90 9
_core/src/definitions 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/config 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers 100 100 50 100
_ index.ts 100 100 50 100
_core/src/definitions/helpers/importCSVMapper 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers/userFriendlySeconds 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/render 88.89 75 100 88.89
_ index.tsx 88.89 75 100 88.89 12
_core/src/definitions/table 72.13 39.29 53.85 71.43
_ index.ts 72.13 39.29 53.85 71.43 12-17,100-110,117-123
_core/src/definitions/upload 18.18 100 0 20
_ index.ts 18.18 100 0 20 12-14,22-30
_core/src/hooks 69.35 25 40 72.88
_ index.ts 100 100 100 100
_ useFileUploadState.ts 17.65 0 0 21.43 10-22,26-35
_ useListResourceQueries.ts 83.87 75 60 83.87 11,27,48,52,58
_core/src/hooks/admin 100 100 100 100
_ index.ts 100 100 100 100
_ useMutationMode.ts 100 100 100 100
_ useSyncWithLocation.ts 100 100 100 100
_ useTitle.tsx 100 100 100 100
_core/src/hooks/admin/useWarnAboutChange 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth 100 100 20 100
_ index.ts 100 100 20 100
_core/src/hooks/auth/useAuthenticated 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/useGetIdentity 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/useLogin 100 50 100 100
_ index.ts 100 50 100 100 24-26
_core/src/hooks/auth/useLogout 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/usePermissions 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/data 59.57 34.57 54.65 60.32
_ index.ts 100 100 72.73 100
_ useApiUrl.ts 100 100 100 100
_ useCreate.ts 83.33 100 60 82.61 64-70
_ useCreateMany.ts 85.71 100 60 85 57-61
_ useCustom.ts 100 75 100 100 38
_ useDelete.ts 48.15 37.25 46.15 50 62,80-108,120-154,164-179,195-199,219-222
_ useDeleteMany.ts 47.95 32.26 42.86 50 65,83-111,123-158,175-178,193-206
_ useList.ts 100 100 100 100
_ useMany.ts 85.71 0 66.67 85.71 33-35
_ useOne.ts 78.57 0 66.67 78.57 32-36
_ useUpdate.ts 48.68 34.48 46.15 50 67,84-112,124-159,174-189,209
_ useUpdateMany.ts 48.05 34.48 42.86 49.28 65,84-112,125-161,176-191,211
_core/src/hooks/fields 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/fields/useCheckboxGroup 100 50 100 100
_ index.ts 100 50 100 100 33-34
_core/src/hooks/fields/useRadioGroup 100 50 100 100
_ index.ts 100 50 100 100 31-32
_core/src/hooks/fields/useSelect 93.75 62.5 85.71 92
_ index.ts 93.75 62.5 85.71 92 49,89
_core/src/hooks/form 90.48 40 33.33 87.88
_ index.ts 100 100 20 100
_ useForm.ts 86.67 40 100 84.62 118-122,126
_core/src/hooks/form/useCloneForm 100 88.24 100 100
_ index.ts 100 100 100 100
_ useCloneForm.ts 100 88.24 100 100 62
_core/src/hooks/form/useCreateForm 65.91 25 22.22 65
_ index.ts 100 100 100 100
_ useCreateForm.ts 64.29 25 12.5 64.1 100-119,127-128,133-136,142
_core/src/hooks/form/useDrawerForm 65.22 37.1 42.86 60.98
_ index.ts 100 100 0 100
_ useDrawerForm.ts 63.64 37.1 50 60 63-65,73-75,84-85,111-127
_core/src/hooks/form/useEditForm 71.43 54.55 33.33 69.35
_ index.ts 100 100 100 100
_ useEditForm.ts 70.59 54.55 27.27 68.85 145-177,186-187,192-195,201
_core/src/hooks/form/useModalForm 68.18 43.48 42.86 65.85
_ index.ts 100 100 0 100
_ useModalForm.ts 66.67 43.48 50 65 92-94,102-105,114-115,142-156
_core/src/hooks/form/useStepsForm 41.67 0 0 36.36
_ index.ts 100 100 0 100
_ useStepsForm.ts 30 0 0 30 32-55
_core/src/hooks/navigation 100 75 100 100
_ index.ts 100 75 100 100 11,21,33,45,55,64-68
_core/src/hooks/notification 100 100 100 100
_ index.ts 100 100 100 100
_ useNotification.ts 100 100 100 100
_core/src/hooks/notification/useCancelNotification 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/hooks/redirection 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource/useMenu 100 76.92 100 100
_ index.tsx 100 76.92 100 100 27,47,52,55
_core/src/hooks/resource/useResource 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource/useResourceWithRoute 90.91 50 100 90
_ index.ts 90.91 50 100 90 13
_core/src/hooks/show 100 92.86 100 100
_ index.ts 100 100 100 100
_ useShow.ts 100 92.86 100 100 29
_core/src/hooks/table 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/table/useEditableTable 84.21 50 42.86 88.24
_ index.ts 100 100 0 100
_ useEditableTable.ts 82.35 50 50 87.5 51,56
_core/src/hooks/table/useTable 64.13 54.69 28.57 59.21
_ index.ts 100 100 100 100
_ useTable.ts 63.33 54.69 16.67 58.67 54,71-80,117-162,167-169
_core/src/hooks/translate 100 75 100 100
_ index.ts 100 100 100 100
_ useGetLocale.ts 100 100 100 100
_ useSetLocale.ts 100 100 100 100
_ useTranslate.ts 100 75 100 100 9
_core/test 100 100 100 100
_ dataMocks.ts 100 100 100 100
_ index.tsx 100 100 100 100
_json-server/src 82.54 53.45 79.41 82.41
_ index.ts 82.54 53.45 79.41 82.41 15-24,33-35,127-135,195,218,222,230,232,235-237
_json-server/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/custom 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_json-server/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/src 78.29 47.62 84.38 76.36
_ index.ts 78.29 47.62 84.38 76.36 30-39,46-54,58-68,188-193,231,245,249,257,259,262-264
_nestjsx-crud/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/custom 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_strapi/src 87.93 59.65 87.1 86.87
_ dataProvider.ts 87.93 59.65 87.1 86.87 14-23,133-134,170,193,197,205,207,210-212
_strapi/src/helpers 100 100 100 100
_ auth.ts 100 100 100 100
_strapi/test/auth 100 100 100 100
_ index.mock.ts 100 100 100 100
_strapi/test/dataProvider 100 100 100 100
_ index.mock.ts 100 100 100 100

@omeraplak omeraplak merged commit 04edde2 into master Jun 1, 2021
@omeraplak omeraplak deleted the explicit-module-boundary-types branch June 1, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omeraplak omeraplak omeraplak approved these changes

Assignees

@umutzd umutzd

Labels
auto-merge help wanted Extra attention is needed review-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@umutzd @omeraplak @refine-bot