Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix useImport bugs #1073

Merged
merged 8 commits into from
Sep 9, 2021
Merged

fix useImport bugs #1073

merged 8 commits into from
Sep 9, 2021

Conversation

umutzd
Copy link
Contributor

@umutzd umutzd commented Sep 8, 2021 •
edited by refine-bot
Loading

Test me! 'MASTER'
Link to FIX-IMPORT-BUGS

closes #1072

Test documentation! 'MASTER'
Link to FIX-IMPORT-BUGS

@umutzd umutzd self-assigned this Sep 8, 2021
@refine-bot
Copy link
Contributor

Hello from PR Helper

Is your PR ready for review and processing? Mark the PR ready by including #pr-ready in a comment.

If you still have work to do, even after marking this ready. Put the PR on hold by including #pr-onhold in a comment.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021 •
edited
Loading

Jest Coverage

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 88.27 70.47 78.37 88.23
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 88.27 70.47 78.37 88.23
_airtable/src 90 88.46 86.67 89.8
_ index.ts 90 88.46 86.67 89.8 74-78,145
_airtable/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_airtable/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_airtable/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_airtable/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_airtable/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_airtable/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_airtable/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_airtable/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_core/src/assets/images 100 100 100 100
_ refine-collapsed.svg 100 100 100 100
_ refine.svg 100 100 100 100
_core/src/components 100 100 25 100
_ index.ts 100 100 25 100
_core/src/components/authenticated 95.65 80 100 95
_ index.tsx 95.65 80 100 95 43
_core/src/components/buttons 100 100 60 100
_ index.ts 100 100 60 100
_core/src/components/buttons/clone 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/create 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/delete 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/edit 95.24 100 50 94.74
_ index.tsx 95.24 100 50 94.74 43
_core/src/components/buttons/export 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/import 100 87.5 100 100
_ index.tsx 100 87.5 100 100 31
_core/src/components/buttons/list 94.44 100 50 94.12
_ index.tsx 94.44 100 50 94.12 37
_core/src/components/buttons/refresh 95.83 100 50 95
_ index.tsx 95.83 100 50 95 49
_core/src/components/buttons/save 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/buttons/show 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/containers 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/containers/refine 81.25 41.3 25 80.36
_ index.tsx 81.25 41.3 25 80.36 117-120,140,193-205
_core/src/components/containers/resource 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/containers/routeProvider 85 78.57 62.5 83.64
_ index.tsx 85 78.57 62.5 83.64 68,84,100,139,178-188
_core/src/components/crud 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/crud/create 100 94.44 100 100
_ index.tsx 100 94.44 100 100 40
_core/src/components/crud/edit 97.06 84.21 50 96.77
_ index.tsx 97.06 84.21 50 96.77 124
_core/src/components/crud/list 100 93.75 100 100
_ index.tsx 100 93.75 100 100 37
_core/src/components/crud/show 96.77 86.36 50 96.43
_ index.tsx 96.77 86.36 50 96.43 95
_core/src/components/fields 100 100 10 100
_ index.ts 100 100 10 100
_core/src/components/fields/boolean 100 83.33 100 100
_ index.tsx 100 83.33 100 100 25,27
_core/src/components/fields/date 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/email 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/file 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/image 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/markdown 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/number 100 80 100 100
_ index.tsx 100 80 100 100 39
_core/src/components/fields/tag 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/text 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/fields/url 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper 88.24 96.15 75 86.21
_ index.tsx 88.24 96.15 75 86.21 65-72,77
_core/src/components/layoutWrapper/components 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/layoutWrapper/components/footer 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/header 100 82.35 100 100
_ index.tsx 100 82.35 100 100 25,31
_core/src/components/layoutWrapper/components/layout 100 50 100 100
_ index.tsx 100 50 100 100 22
_core/src/components/layoutWrapper/components/offLayoutArea 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/layoutWrapper/components/sider 100 70.59 100 100
_ index.tsx 100 70.59 100 100 33-35,50-75
_ styles.ts 100 100 100 100
_core/src/components/layoutWrapper/components/title 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/notification 87.5 66.67 80 87.5
_ index.tsx 87.5 66.67 80 87.5 54-62
_core/src/components/notification/components 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/notification/components/notificationProgress 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/pages 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/pages/error 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/pages/login 94.74 100 50 94.12
_ index.tsx 93.33 100 50 92.31 67
_ styles.ts 100 100 100 100
_core/src/components/pages/ready 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/components/routeChangeHandler 100 75 100 100
_ index.tsx 100 75 100 100 13
_core/src/components/table 100 100 100 100
_ index.ts 100 100 100 100
_core/src/components/table/components 100 100 0 100
_ index.ts 100 100 0 100
_core/src/components/table/components/filterDropdown 87.5 58.33 100 86.11
_ index.tsx 87.5 58.33 100 86.11 42-43,52-53,63
_core/src/contexts/auth 92.59 58.33 71.43 90.24
_ index.tsx 92.59 58.33 71.43 90.24 7-8,10-11
_core/src/contexts/components 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/data 100 50 100 100
_ index.tsx 100 50 100 100 36
_core/src/contexts/notification 91.18 71.43 80 90
_ actionTypes.ts 100 100 100 100
_ index.ts 100 100 100 100
_ notificationContext.tsx 88 66.67 66.67 86.36 11,22,50
_core/src/contexts/refine 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/resource 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/contexts/translation 90 100 75 90
_ index.tsx 90 100 75 90 9
_core/src/contexts/unsavedWarn 33.33 100 0 50
_ index.tsx 33.33 100 0 50 7,11-13
_core/src/definitions 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/config 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers/handleNotification 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers/importCSVMapper 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/helpers/userFriendlyResourceName 100 75 100 100
_ index.ts 100 75 100 100 5
_core/src/definitions/helpers/userFriendlySeconds 100 100 100 100
_ index.ts 100 100 100 100
_core/src/definitions/table 96.34 79.55 100 95.77
_ index.ts 96.34 79.55 100 95.77 98,107,124
_core/src/definitions/upload 86.67 50 80 86.67
_ index.ts 86.67 50 80 86.67 25-26
_core/src/hooks 90.91 50 73.33 90.48
_ index.ts 100 100 100 100
_ useFileUploadState.ts 88.24 25 100 85.71 18,35
_ useListResourceQueries.ts 87.1 100 60 87.1 11,27,48,52
_core/src/hooks/auth 100 100 83.33 100
_ index.ts 100 100 83.33 100
_core/src/hooks/auth/useAuthenticated 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/useCheckError 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/useGetIdentity 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/auth/useLogin 100 71.43 100 100
_ index.ts 100 71.43 100 100 47-48
_core/src/hooks/auth/useLogout 94.44 70 100 94.44
_ index.ts 94.44 70 100 94.44 40
_core/src/hooks/auth/usePermissions 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/data 70.7 43.46 68.18 71.83
_ index.ts 100 100 72.73 100
_ useApiUrl.ts 100 100 100 100
_ useCreate.ts 78.57 100 60 80 86-96
_ useCreateMany.ts 96 100 80 95.45 81
_ useCustom.ts 83.33 37.5 75 83.33 66-69
_ useDelete.ts 63.44 36.59 66.67 64.38 97,101,105,133-168,180-194,214-217,240-243
_ useDeleteMany.ts 63.22 48.57 61.54 65.75 102,106,110,137-173,187-190,216-227
_ useList.ts 83.33 50 75 83.33 60-63
_ useMany.ts 83.33 50 75 83.33 51-54
_ useOne.ts 82.35 43.75 75 82.35 50-53
_ useUpdate.ts 64.44 38.46 66.67 64.29 98,102,106,134-172,189-203,224
_ useUpdateMany.ts 63.74 48.57 61.54 65.79 106,110,114,142-181,198-212,230
_core/src/hooks/export 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/fields 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/fields/useCheckboxGroup 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/fields/useRadioGroup 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/fields/useSelect 95.56 93.75 100 94.74
_ index.ts 95.56 93.75 100 94.74 132-133
_core/src/hooks/form 97.62 86.67 33.33 96.97
_ index.ts 100 100 20 100
_ useForm.ts 96.67 86.67 100 96.15 133
_core/src/hooks/form/useCloneForm 100 92.31 100 100
_ index.ts 100 100 100 100
_ useCloneForm.ts 100 92.31 100 100 66
_core/src/hooks/form/useCreateForm 68.63 25 36.36 68.09
_ index.ts 100 100 100 100
_ useCreateForm.ts 67.35 25 30 67.39 107-133,147-148,153-156,162
_core/src/hooks/form/useDrawerForm 66.67 37.1 42.86 62.79
_ index.ts 100 100 0 100
_ useDrawerForm.ts 65.22 37.1 50 61.9 95-97,105-107,116-117,122-139
_core/src/hooks/form/useEditForm 72.22 52.5 33.33 70.31
_ index.ts 100 100 100 100
_ useEditForm.ts 71.43 52.5 27.27 69.84 148-188,197-198,203-206,212
_core/src/hooks/form/useModalForm 80 62.07 66.67 78.72
_ index.ts 100 100 0 100
_ useModalForm.ts 79.17 62.07 80 78.26 110-112,120-123,136-146
_core/src/hooks/form/useStepsForm 83.33 53.85 25 81.82
_ index.ts 100 100 0 100
_ useStepsForm.ts 80 53.85 33.33 80 52,66
_core/src/hooks/import 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/hooks/list 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/list/useSimpleList 74.36 66.67 28.57 76.19
_ index.ts 100 100 0 100
_ useSimpleList.ts 73.68 66.67 33.33 75.81 119-125,137-146,167-168,172-176
_core/src/hooks/modal 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/modal/useModal 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/hooks/navigation 100 90 100 100
_ index.ts 100 90 100 100 18,54
_core/src/hooks/notification 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/notification/useCancelNotification 100 100 100 100
_ index.tsx 100 100 100 100
_core/src/hooks/redirection 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/refine 100 100 100 100
_ index.ts 100 100 100 100
_ useMutationMode.ts 100 100 100 100
_ useSyncWithLocation.ts 100 100 100 100
_ useTitle.tsx 100 100 100 100
_core/src/hooks/refine/useWarnAboutChange 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource/useMenu 95.65 68.18 100 95.65
_ index.tsx 95.65 68.18 100 95.65 35
_core/src/hooks/resource/useResource 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/resource/useResourceWithRoute 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/show 100 92.86 100 100
_ index.ts 100 100 100 100
_ useShow.ts 100 92.86 100 100 46
_core/src/hooks/table 100 100 100 100
_ index.ts 100 100 100 100
_core/src/hooks/table/useEditableTable 84.21 50 42.86 88.24
_ index.ts 100 100 0 100
_ useEditableTable.ts 82.35 50 50 87.5 66,71
_core/src/hooks/table/useTable 72.09 66.07 37.5 73.97
_ index.ts 100 100 100 100
_ useTable.ts 71.43 66.07 28.57 73.61 108-114,136-148,186-196,200-206
_core/src/hooks/translate 100 75 100 100
_ index.ts 100 100 100 100
_ useGetLocale.ts 100 100 100 100
_ useSetLocale.ts 100 100 100 100
_ useTranslate.ts 100 75 100 100 15
_core/test 100 100 100 100
_ dataMocks.ts 100 100 100 100
_ index.tsx 100 100 100 100
_nestjsx-crud/src 78.95 52.17 84.38 77.19
_ index.ts 78.95 52.17 84.38 77.19 30-39,46-54,58-68,188-193,231,249,253,261,263,266-268
_nestjsx-crud/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/custom 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_nestjsx-crud/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/src 82.09 56.06 79.41 81.9
_ index.ts 82.09 56.06 79.41 81.9 15-24,33-35,65-66,139-150,210,236,240,248,250,253-255
_simple-rest/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/custom 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_simple-rest/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_strapi/src 87.93 59.65 87.1 86.73
_ dataProvider.ts 87.93 59.65 87.1 86.73 14-23,131-132,168,191,195,203,205,208-210
_strapi/src/helpers 100 100 100 100
_ auth.ts 100 100 100 100
_strapi/test/auth 100 100 100 100
_ index.mock.ts 100 100 100 100
_strapi/test/dataProvider 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/src 100 82.14 100 100
_ index.ts 100 82.14 100 100 31-32,50,62,70,89,100,116,127,138
_supabase/test 100 100 100 100
_ supabaseClient.ts 100 100 100 100
_supabase/test/create 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/createMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/deleteMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/deleteOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/getList 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/getMany 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/getOne 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/update 100 100 100 100
_ index.mock.ts 100 100 100 100
_supabase/test/updateMany 100 100 100 100
_ index.mock.ts 100 100 100 100

@umutzd umutzd changed the title [WIP] fix useImport bugs fix useImport bugs Sep 9, 2021
@omeraplak omeraplak merged commit e9e43a1 into master Sep 9, 2021
@omeraplak omeraplak deleted the fix-import-bugs branch September 9, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omeraplak omeraplak omeraplak approved these changes

@biskuvit biskuvit Awaiting requested review from biskuvit

@yildirayunlu yildirayunlu Awaiting requested review from yildirayunlu

Assignees

@umutzd umutzd

Labels
auto-merge pr-ready review-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useImport bugs
3 participants
@umutzd @refine-bot @omeraplak