Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-check tests #4489

Merged
merged 7 commits into from
Apr 16, 2023
Merged

Type-check tests #4489

merged 7 commits into from
Apr 16, 2023

Conversation

Methuselah96
Copy link
Member

In #4487 we switched from ts-jest (which runs type-checking on test files) to Vitest (which does not).

This PR runs type-checking on the tests to make sure they pass.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6714d12:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@markerikson
Copy link
Contributor

Hmm. Apparently the optimization I added / copied that tries to skip tests if there are no src changes is skipping the tests here too :(

While you're at it, can you try tweaking the condition to run if there's changes to .github?

Worst case, just kill the condition and always run the tests for now.

@Methuselah96
Copy link
Member Author

Odd test failure for TypeScript 4.1. I'll take a look later.

@Methuselah96
Copy link
Member Author

Methuselah96 commented Feb 15, 2023

rxjs types only supports >=4.2 👀

  "name": "rxjs",
  ...
  "typesVersions": {
    ">=4.2": {
      "*": [
        "dist/types/*"
      ]
    }
  },

@Methuselah96
Copy link
Member Author

Methuselah96 commented Feb 15, 2023

I think we're good to drop testing against TypeScript 4.1? It came out on 11/19/20 so it's older than the 2-year support window defined by DefinitelyTyped.

@markerikson
Copy link
Contributor

Yep, absolutely! We've generally done rolling TS version compat in our minor releases anyway, so let's drop 4.1 from the test matrix. (Might as well add 5.0-beta while we're at it?)

@netlify
Copy link

netlify bot commented Apr 16, 2023

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit d4ff426
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/643c4508b833080008ce963f
😎 Deploy Preview https://deploy-preview-4489--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markerikson markerikson merged commit 3f96517 into reduxjs:master Apr 16, 2023
@Methuselah96 Methuselah96 deleted the tests-typecheck branch April 16, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants