Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated packages by upgrading @babel/cli to version 7.16.7 #4258

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

mxweaver
Copy link
Contributor

@mxweaver mxweaver commented Jan 9, 2022

I noticed some deprecated package warnings when I was installing dependencies:

madison ~/projects/redux 
532 ߷  rm -rf node_modules && npm ci 
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated

added 1029 packages, and audited 1030 packages in 13s

88 packages are looking for funding
  run `npm fund` for details

1 moderate severity vulnerability

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

After looking into these packages, it seems that they are only depended upon by one package in the project, @babel/cli:


madison ~/projects/redux 
533 ߷  npm ls urix                  
[email protected] /Users/madison/projects/redux
└─┬ @babel/[email protected]
  └─┬ @nicolo-ribaudo/[email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └── [email protected]


madison ~/projects/redux 
534 ߷  npm ls resolve-url           
[email protected] /Users/madison/projects/redux
└─┬ @babel/[email protected]
  └─┬ @nicolo-ribaudo/[email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └─┬ [email protected]
          └── [email protected]

After upgrading @babel/cli, the urix and resolve-url packages seem to no longer be needed:

madison ~/projects/redux 
543 ߷  npm ls urix                                                           
[email protected] /Users/madison/projects/redux
└── (empty)


madison ~/projects/redux 
544 ߷  npm ls resolve-url                                                    
[email protected] /Users/madison/projects/redux
└── (empty)

Changelog

  • Removed dependencies to the deprecated urix and resolve-url packages by upgrading @babel/cli to version 7.16.7

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db7b6ab:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@mxweaver mxweaver changed the title Upgrade @babel/cli Removed deprecated packages by upgrading @babel/cli to version 7.16.7 Jan 9, 2022
@markerikson
Copy link
Contributor

Heh, and we're just rippling the package conflicts down through one PR at a time :)

If you see any other packages that ought to be updated now, might as well go ahead and roll them into this PR too.

@netlify
Copy link

netlify bot commented Jan 10, 2022

✔️ Deploy Preview for redux-docs ready!

🔨 Explore the source changes: db7b6ab

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/61db92046fd1bc0008aabec5

😎 Browse the preview: https://deploy-preview-4258--redux-docs.netlify.app

@markerikson markerikson merged commit 02a6e5a into reduxjs:master Jan 10, 2022
nevilm-lt pushed a commit to nevilm-lt/redux that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants