Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable TypeScript tests #3770

Merged
merged 2 commits into from
May 11, 2020
Merged

Conversation

Methuselah96
Copy link
Member

@Methuselah96 Methuselah96 commented May 9, 2020


name: "Re-enable TypeScript tests"
about: Testing is important

PR Type

Does this PR add a new feature, or fix a bug?

Internal change.

Why should this PR be included?

See #3500 (comment) and following. I tried out tsd, but I did not like it as much. The expect() method syntax made it more cumbersome to assert in some scenarios. It also wasn't very well documented. I had to read the source code to figure out how to use it. So, I think sticking with typings-tester is preferable for now.

Note, I also needed to add an import in types\store.ts in order to get the global Symbol.observable definition working in the type outputs.

Checklist

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Is there an existing issue for this PR?
    • No, this is an internal change.
  • Have the files been linted and formatted?
  • Have the docs been updated to match the changes in the PR?
  • Have the tests been updated to match the changes in the PR?
  • Have you run the tests locally to confirm they pass?

Bug Fixes

What is the current behavior, and the steps to reproduce the issue?

Types can break.

What is the expected behavior?

The ability to test types.

How does this PR fix the problem?

Re-enables types testing.

@netlify
Copy link

netlify bot commented May 9, 2020

Deploy preview for redux-docs ready!

Built with commit 916626b

https://deploy-preview-3770--redux-docs.netlify.app

@timdorr
Copy link
Member

timdorr commented May 11, 2020

Ah, we had somehow missed this. Thanks for catching and fixing it!

@timdorr timdorr merged commit 1766b93 into reduxjs:master May 11, 2020
@Methuselah96 Methuselah96 deleted the try-og-tests branch May 11, 2020 00:51
alokreddy pushed a commit to alokreddy/redux that referenced this pull request Sep 30, 2020
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Former-commit-id: de2e435
Former-commit-id: 512bd6d
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Former-commit-id: de2e435
Former-commit-id: 512bd6d
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Former-commit-id: de2e435
Former-commit-id: 512bd6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants