Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ServerRendering.md #1263

Merged
merged 1 commit into from
Jan 24, 2016
Merged

Update ServerRendering.md #1263

merged 1 commit into from
Jan 24, 2016

Conversation

paoyong
Copy link
Contributor

@paoyong paoyong commented Jan 22, 2016

On the Server Rendering Redux recipe, the <div id="root"> and document.getElementById('app') do not match.

Screenshots:

screen shot 2016-01-22 at 10 56 34 am
screen shot 2016-01-22 at 10 56 48 am

Fix
Use app for both id's.

Change

`document.getElementById('root')`

to 

`document.getElementById('root')`

to match the earlier

`<div id="root">${html}</div>`
@dukex
Copy link

dukex commented Jan 24, 2016

Nice! LGTM

gaearon added a commit that referenced this pull request Jan 24, 2016
@gaearon gaearon merged commit c6cd6d8 into reduxjs:master Jan 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants