-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codegen-openapi tests #4307
Open
aryaemami59
wants to merge
67
commits into
reduxjs:master
Choose a base branch
from
aryaemami59:fix-codegen-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+836
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0fa590e:
|
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…dux-toolkit; branch 'master' of https://github.com/reduxjs/redux-toolkit into fix-codegen-tests
…dux-toolkit; branch 'master' of https://github.com/reduxjs/redux-toolkit into fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
…o fix-codegen-tests
aryaemami59
force-pushed
the
fix-codegen-tests
branch
from
June 21, 2024 12:02
e12e592
to
1bc2b72
Compare
…o fix-codegen-tests
…o fix-codegen-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously the codegen tests would create side effects which made them unpredictable and caused them to produce inconsistent results. This PR mainly focuses on making the unit tests reliable both during local development and CI.
This PR:
cli
command incli.test.ts
with a promisified version of Node'sexec
which mimicks the actual cli behavior more closely.importHelpers
for a slightly smaller bundle size.tsconfig
setup to have atsconfig.build.json
andtsconfig.json
as opposed to atest/tsconfig.json
withbaseUrl
.lib
folder during CI.vite-tsconfig-paths
was added todevDependencies
to manage this easier.fileParallelism
for unit tests in order to minimize side effects.