Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oazapfts to 6.0.2 #4198

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

SimonEggert
Copy link
Contributor

@SimonEggert SimonEggert commented Feb 14, 2024

Some issues (s. #3814) have been fixed in upstream library oazapfts so this is an attempt to update it to the latest version.

The major updates that this update has stepped over are mainly regarding changes to exported files that have been addressed by this PR.

oazapfts now includes comments in the generated types, so I also needed to update the snapshot tests.

closes #3814

Copy link

codesandbox bot commented Feb 14, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 7939056
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/660e97add64165000888e8df
😎 Deploy Preview https://deploy-preview-4198--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Feb 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7939056:

Sandbox Source
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link
Contributor Author

@SimonEggert SimonEggert Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were necessary to fix errors regarding the new import structure that does not seem to work (for TypeScript at least), s. this workflow run. I am not fully aware of the implications this might have for building and packaging, so please take a closer look.

@mattoni
Copy link

mattoni commented Apr 1, 2024

Any update to this? Definitely would love to have the updates to oazapfts :)

@SimonEggert
Copy link
Contributor Author

I am trying to keep this PR up to date with master to keep it reviewable, but I haven't heard back.

@markerikson, you have responded in the corresponding issue a while ago. Any chance you could look into this PR any time soon? I'd be glad to rework anything that prevents this PR from being merged.

@yamilelias
Copy link

I'm currently working on a project that could use this update! I'm happy to contribute if needed.

By the way, oazapfts already updated the package to address negative enum values on version 6.0.6 which solves issue #4455. The latest version is 6.0.10, so many fixes could be included. Let me know if you guys need some help.

@markerikson
Copy link
Collaborator

@yamilelias , @SimonEggert : yeah, apologize for the complete delay and falling through the cracks on this one. There's been a couple factors. Lenz did all the initial work on the codegen, but hasn't had much time for Redux maintenance over the last year. I've been busy with personal life and all my Redux-related time this year has gone to trying to update our tutorial (and frankly also tried to filter out all codegen related discussion because I haven't worked on it and I don't have the brain space to think about it).

Skimming this, it seems reasonable at first glance.

I'll go ahead and merge this and then figure out how to get this published!

@markerikson markerikson merged commit d471d7c into reduxjs:master Jun 13, 2024
5 checks passed
@markerikson
Copy link
Collaborator

Drat. Tried to publish it and ran into some kind of an NPM-related issue.

I don't have time to investigate this now, but I will try to look at it as soon as i have time. (Realistically that may not be until Sunday or early next week.)

@SimonEggert SimonEggert deleted the update-oazapfts branch June 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rtk-query-codegen-openapi: Null values not always respected
4 participants