mvlog/tests: clean up files in test body #18554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that death tests were leaving behind some directories, even
though the test appears to be exiting successfully.
It turns out that because death tests run a separate process[1], it was
creating an extra directory, but not running the teardown because of the
process crash.
So this hacks the tests to clean up in the test body before the crash.
[1] https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests-and-threads
Backports Required
Release Notes