Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for a redundant AMQP URL #912

Merged
merged 10 commits into from
Oct 22, 2021
Merged

Allow for a redundant AMQP URL #912

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5fdf8f1
wip
dviramontes Oct 20, 2021
8ba3c2a
rename receiver
dviramontes Oct 21, 2021
9ace20e
pr feedback
dviramontes Oct 21, 2021
40a83ed
update field doc
dviramontes Oct 21, 2021
b52258f
update doc md
dviramontes Oct 21, 2021
b0e89f4
remove empty file
dviramontes Oct 21, 2021
795c0ae
refactor reDial fn
dviramontes Oct 21, 2021
ee23dc4
update function comment, reset conf.URLs when conf.URL is present
dviramontes Oct 22, 2021
74a7df9
update integration test with fallback URL
dviramontes Oct 22, 2021
c3cc74c
add backwards compatibility test
dviramontes Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update doc md
  • Loading branch information
@dviramontes
dviramontes committed Oct 21, 2021
commit b52258fc3537dbe1c62ddc6589d73b1d1fc1f8d7
24 changes: 16 additions & 8 deletions website/docs/components/inputs/amqp_0_9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ message brokers, including RabbitMQ.
input:
label: ""
amqp_0_9:
url: amqp:https://guest:guest@localhost:5672/
urls:
- amqp:https://guest:guest@localhost:5672/
queue: benthos-queue
consumer_tag: benthos-consumer
prefetch_count: 10
Expand All @@ -46,7 +47,8 @@ input:
input:
label: ""
amqp_0_9:
url: amqp:https://guest:guest@localhost:5672/
urls:
- amqp:https://guest:guest@localhost:5672/
queue: benthos-queue
queue_declare:
enabled: false
Expand Down Expand Up @@ -101,20 +103,26 @@ You can access these metadata fields using

## Fields

### `url`
### `urls`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result of running make docs not sure if this step should be part of the PR or maybe its automated ?


A URL to connect to.
A list of URLs to connect to. If an item of the list contains commas it will be expanded into multiple URLs.


Type: `string`
Default: `"amqp:https://guest:guest@localhost:5672/"`
Type: `array`
Default: `["amqp:https://guest:guest@localhost:5672/"]`

```yaml
# Examples

url: amqp:https://localhost:5672/
urls:
- amqp:https://127.0.0.1:5672/

urls:
- amqp:https://127.0.0.1:5672/,amqp:https://127.0.0.2:5672/

url: amqps:https://guest:guest@localhost:5672/
urls:
- amqp:https://127.0.0.1:5672/
- amqp:https://127.0.0.2:5672/
```

### `queue`
Expand Down