Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset_visibility param to aws_sqs input #911

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

ekeric13
Copy link
Contributor

@ekeric13 ekeric13 commented Oct 20, 2021

Closes: #910

Add an additional parameter of reset_visibility to the aws_sqs input.

Determines whether to set the visibility of the timeout of a nack-ed message to 0, or to leave it unchanged. Just the way delete_message determines whether to delete an ack-ed message, or leave it unchanged.

reset_visibility defaults to true, retaining backwards compatibility.

@ekeric13
Copy link
Contributor Author

ekeric13 commented Oct 20, 2021

Unit tests seemed to pass.
Ran make install to create the binary and then make test to test it against the example configs

Screen Shot 2021-10-20 at 1 15 15 PM

Some of the integration tests failed though.

Screen Shot 2021-10-20 at 1 07 21 PM

Docs mentioned the integration tests might fail though. Are there other dependencies I need to install locally?

It doesn't seem there are any tests around aws_sqs input so definitely surprised to get some failures.

@ekeric13 ekeric13 marked this pull request as ready for review October 20, 2021 20:28
@Jeffail
Copy link
Collaborator

Jeffail commented Oct 20, 2021

Thanks @ekeric13, looks great. Don't worry about the integration tests, running them all at the same time on most machines times out. It's an item on my TODO list to improve the contributor docs for integration testing.

@Jeffail Jeffail merged commit 6d48246 into redpanda-data:master Oct 20, 2021
@ekeric13 ekeric13 deleted the aws-sqs-input-reset-visibility branch October 20, 2021 20:56
@ekeric13
Copy link
Contributor Author

Awesome! Pretty easy process adding a new PR.
What is the release cadence? Definitely excited to try it out when it's available.

@Jeffail
Copy link
Collaborator

Jeffail commented Oct 20, 2021

It's likely to be the end of this week (or weekend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow aws sqs input to respect visibilityTimeout on Nacks
2 participants