Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMQP TLS EXTERNAL auth support #905

Merged

Conversation

mihaitodor
Copy link
Collaborator

@mihaitodor mihaitodor commented Oct 15, 2021

Also switch to the RabbitMQ team official Go client library for AMQP 0.91. It will take a while longer for this library to get a new release, since the maintainers want to fix a few bugs before, so, for now, I pinned it to the latest commit on the main branch (60a96d5).

This was tested with the RabbitMQ container and producer / consumer demo apps described here https://github.com/mihaitodor/amqp_tls_go_demo while running Benthos with the following two configs:

input:
  amqp_0_9:
    url: amqps:https://localhost:5671/
    queue: test-queue
    queue_declare:
      enabled: true
      durable: true
    bindings_declare:
      - exchange: test-exchange
        key: test-key
    consumer_tag: simple-consumer
    auto_ack: false
    prefetch_count: 10
    prefetch_size: 0
    tls:
      enabled: true
      skip_cert_verify: true
      enable_renegotiation: false
      root_cas_file: "ca-cert.pem"
      client_certs:
        - cert_file: "client-cert.pem"
          key_file: "client-privkey.pem"
output:
  stdout: {}
input:
  stdin: {}
output:
  amqp_0_9:
    url: amqps:https://localhost:5671/
    exchange: test-exchange
    exchange_declare:
      enabled: false
      type: direct
      durable: true
    key: test-key
    type: ""
    content_type: application/octet-stream
    content_encoding: ""
    metadata:
      exclude_prefixes: []
    priority: ""
    max_in_flight: 1
    persistent: false
    mandatory: false
    immediate: false
    tls:
      enabled: true
      skip_cert_verify: true
      enable_renegotiation: false
      root_cas_file: "ca-cert.pem"
      client_certs:
        - cert_file: "client-cert.pem"
          key_file: "client-privkey.pem"

@mihaitodor mihaitodor changed the title Add AMQL TLS EXTERNAL auth support Add AMQP TLS EXTERNAL auth support Oct 15, 2021
@mihaitodor mihaitodor force-pushed the add_amqp_tls_external_auth_support branch 2 times, most recently from 64808ba to c367c67 Compare October 15, 2021 13:42
Also switch to the RabbitMQ team official Go client library for
AMQP 0.91.
@mihaitodor mihaitodor force-pushed the add_amqp_tls_external_auth_support branch from c367c67 to 399127a Compare October 15, 2021 13:55
@Jeffail
Copy link
Collaborator

Jeffail commented Oct 18, 2021

Awesome, thanks @mihaitodor!

@Jeffail Jeffail merged commit 68801ab into redpanda-data:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants