Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make broker connection retry interval configurable in kafka sarama input #2679

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cll-gg
Copy link
Contributor

@cll-gg cll-gg commented Jun 24, 2024

When the sarama loses its connection with the broker, it retries to establish it.
By default, the interval for retrying is set to 250ms (see here).

What we occasionally observe is that when a kafka cluster instance restarts, there's a thundering herd of benthos consumers retrying the connection. If we make the interval configurable, we can improve this situation.

I'm also open to making a PR to make the whole sarama retry config configurable, made a draft PR for that here, but maybe that's overkill.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants