Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes on lru and ttlru caches #2068

Merged
merged 37 commits into from
Sep 1, 2023

Conversation

peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Aug 18, 2023

add option default_ttl on ttlru cache to substitute ttl at some point

improve locking usage

add deduplication tests

update docs

this pull request fixes

issue #2066
issue #2067

when checking the updates on the lru libraries, I discover a new expirable queue github.com/hashicorp/golang-lru/v2/expirable that can replace the ttlru inner implementation

@peczenyj peczenyj requested a review from Jeffail as a code owner August 18, 2023 07:16
@peczenyj peczenyj changed the title small fixes on lru and ttlru small fixes on lru and ttlru caches Aug 18, 2023
@peczenyj
Copy link
Contributor Author

peczenyj commented Aug 18, 2023

last commit was to unblock the pull request #2064

@peczenyj peczenyj force-pushed the fix-cache-lru-and-ttlru branch 2 times, most recently from bd923c5 to d2ca852 Compare August 22, 2023 18:40
peczenyj and others added 25 commits August 22, 2023 20:40
add option `default_ttl` on ttlru cache to substitute ttl at some point

improve locking usage

add deduplication tests

update docs

Signed-off-by: Tiago Peczenyj <[email protected]>
…golang-lru/v2/expirable

Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
…with current inner implementation

Signed-off-by: Tiago Peczenyj <[email protected]>
* Added dependabot to keep go dependencies & actions updated.

Signed-off-by: Neo2308 <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
(Aiming to) reduce the frequency of PRs, I'm pretty sure daily separate PRs will swamp us very quickly. We can tune this again later.

Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
* Bump crazy-max/ghaction-docker-meta from 2 to 4

Bumps [crazy-max/ghaction-docker-meta](https://github.com/crazy-max/ghaction-docker-meta) from 2 to 4.
- [Release notes](https://github.com/crazy-max/ghaction-docker-meta/releases)
- [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md)
- [Commits](docker/metadata-action@v2...v4)

---
updated-dependencies:
- dependency-name: crazy-max/ghaction-docker-meta
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update release.yml

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ashley Jeffs <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v2...v4)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1 to 2.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v1...v2)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v1...v2)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Joseph Woodward <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Jeffail and others added 12 commits August 22, 2023 20:40
Signed-off-by: Tiago Peczenyj <[email protected]>
solves: benthos redpanda-data#2072
Signed-off-by: Andreas Zilly <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Adding ecdsa sign and parse methods
Adding parse_jwt_rs methods
Adding parse_jwt_rs methods

Signed-off-by: iquirino <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Ryan Hall <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Philipp Kuebler <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Adam Rudd <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Adam Rudd <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Copy link
Collaborator

@Jeffail Jeffail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @peczenyj!

@Jeffail Jeffail merged commit 96f872d into redpanda-data:main Sep 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants