-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small fixes on lru and ttlru caches #2068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last commit was to unblock the pull request #2064 |
bd923c5
to
d2ca852
Compare
add option `default_ttl` on ttlru cache to substitute ttl at some point improve locking usage add deduplication tests update docs Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
…golang-lru/v2/expirable Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
…with current inner implementation Signed-off-by: Tiago Peczenyj <[email protected]>
* Added dependabot to keep go dependencies & actions updated. Signed-off-by: Neo2308 <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
(Aiming to) reduce the frequency of PRs, I'm pretty sure daily separate PRs will swamp us very quickly. We can tune this again later. Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
* Bump crazy-max/ghaction-docker-meta from 2 to 4 Bumps [crazy-max/ghaction-docker-meta](https://github.com/crazy-max/ghaction-docker-meta) from 2 to 4. - [Release notes](https://github.com/crazy-max/ghaction-docker-meta/releases) - [Upgrade guide](https://github.com/docker/metadata-action/blob/master/UPGRADE.md) - [Commits](docker/metadata-action@v2...v4) --- updated-dependencies: - dependency-name: crazy-max/ghaction-docker-meta dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update release.yml --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashley Jeffs <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3 to 4. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v2...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v1...v2) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v1...v2) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Joseph Woodward <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
solves: benthos redpanda-data#2072 Signed-off-by: Andreas Zilly <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Adding ecdsa sign and parse methods Adding parse_jwt_rs methods Adding parse_jwt_rs methods Signed-off-by: iquirino <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Ryan Hall <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Philipp Kuebler <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Adam Rudd <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Adam Rudd <[email protected]> Signed-off-by: Tiago Peczenyj <[email protected]>
Signed-off-by: Tiago Peczenyj <[email protected]>
Jeffail
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @peczenyj!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add option
default_ttl
on ttlru cache to substitute ttl at some pointimprove locking usage
add deduplication tests
update docs
this pull request fixes
issue #2066
issue #2067
when checking the updates on the lru libraries, I discover a new expirable queue github.com/hashicorp/golang-lru/v2/expirable that can replace the ttlru inner implementation