Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encrypted TLS private keys #1300

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

chrisdoc
Copy link
Contributor

Context:
We use TLS Certificates with an encrypted private key to connect to our Kafka brokers. Therefore I thought it would be a good idea to add support for encrypted keys to benthos.

Solution:
Decode the provided key and check if it is encrypted and try to decrypt it with the user provided password. I have added test for both certificates as file and string.

@Jeffail
Copy link
Collaborator

Jeffail commented Jun 19, 2022

Thanks @chrisdoc looks great, just need to add an additional entry to https://github.com/benthosdev/benthos/blob/main/internal/tls/docs.go#L44 in order for the documentation to match.

@chrisdoc chrisdoc force-pushed the feat/tls-encrypted-key branch 2 times, most recently from c88fafa to a70fb53 Compare June 19, 2022 11:41
@chrisdoc
Copy link
Contributor Author

@Jeffail thank you for the fast feedback; I went ahead and added the missing documentation update :)

@Jeffail
Copy link
Collaborator

Jeffail commented Jun 22, 2022

Awesome, thanks @chrisdoc, extra ❤️ for adding more tests

@Jeffail Jeffail merged commit 7f35b4d into redpanda-data:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants