Support expressions in redis output stream field #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarinov
commented
Jun 7, 2022
bmarinov
commented
Jun 7, 2022
bmarinov
commented
Jun 7, 2022
bmarinov
commented
Jun 7, 2022
| @@ -137,7 +142,7 @@ func (r *redisStreamsWriter) WriteWithContext(ctx context.Context, msg *message. | |||
| if msg.Len() == 1 { | |||
| if err := client.XAdd(&redis.XAddArgs{ | |||
| ID: "*", | |||
| Stream: r.conf.Stream, | |||
| Stream: r.interpolatedStreamName.String(0, msg), | |||
There was a problem hiding this comment.
This magic value (index 0) is due to the fact that there is a single message in the batch. Is it obvious enough and have I understood the message loop for the expression handling correctly?
mihaitodor
reviewed
Jun 7, 2022
|
Thanks @bmarinov, looks great. I'll fix merge conflicts on my end as I've been refactoring constructor signatures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes #1083
This is a quick fix for the lack of expression support in the
streamconfiguration on the redis stream outputoutput.redis_streams.streamconfig field.I tried to follow the integration test setup for redis, but in the end I had to add a new test that allows for additional metadata to be set on messages.
I have a couple of questions and some todo's - adding comments on the PR.